Javascript simple regexp doesn't work

Question

I have this code, it looks alright and is really basic, but i can't make it work:

function checkValid(elem){

 var abc = elem.value;

 var re = "/[0-9]/";

 var match = re.test(abc);

 alert(match);
}

It matches 0 and 9, but not 1 to 8, what's wrong here? Thanks.

SLaks · Accepted Answer · 2010-05-16 23:28:16Z

3

re is a string, not a RegExp object.

You need to use a regex literal instead of a string literal, like this:

var re = /[0-9]/;

Also, this will return true for any string that contains a number anywhere in the string.
You probably want to change it to

var re = /^[0-9]+$/;

answered May 16, 2010 at 23:28

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gabe · Accepted Answer · 2010-05-16 23:29:05Z

2

Try removing the double quotes...

 var re = /[0-9]/;

answered May 16, 2010 at 23:29

Gabe

50.6k29 gold badges147 silver badges182 bronze badges

Ryan Bigg · Accepted Answer · 2010-05-16 23:29:21Z

0

Use \d to match a number and make it a regular expresison, not a string:

var abc = elem.value;
var re = /\d/;
var match = re.test(abc);
alert(match);

answered May 16, 2010 at 23:29

Ryan Bigg

108k25 gold badges243 silver badges264 bronze badges