C# Web API call

Question

This is the first time i've tried making a call to an API and I'm struggling a little. I keep getting back my error message, I plan on using the json response to populate my object. The OMDB api instructions are here (not helpful though): http://www.omdbapi.com/

private static async Task RunAsync()
{
    using (var client = new HttpClient())
    {
        client.BaseAddress = new Uri("http://www.omdbapi.com/?");
        client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));

        HttpResponseMessage response = client.GetAsync("t=Captain+Phillips&r=json").Result;

        if (response.IsSuccessStatusCode)
        {
            Console.WriteLine("Success");
        }
        else
        {
            Console.WriteLine("Error with feed");
        }
    }
}

What error are you getting?

Yuval Itzchakov
– Yuval Itzchakov

2015-01-25 13:40:23 +00:00
Commented Jan 25, 2015 at 13:40 — Yuval Itzchakov
– Yuval Itzchakov, Commented Jan 25, 2015 at 13:40

Darin Dimitrov · Accepted Answer · 2015-01-25 13:45:01Z

4

You have placed the question mark (?) on the wrong place. Try like this:

private static async Task RunAsync()
{
    using (var client = new HttpClient())
    {
        client.BaseAddress = new Uri("http://www.omdbapi.com");
        client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));

        HttpResponseMessage response = await client.GetAsync("?t=Captain+Phillips&r=json");

        if (response.IsSuccessStatusCode)
        {
            Console.WriteLine("Success");
        }
        else
        {
            Console.WriteLine("Error with feed");
        }
    }
}

Notice that the question mark is here:

HttpResponseMessage response = await client.GetAsync("?t=Captain+Phillips&r=json");

and not on the base url as you placed it.

Also in order to properly write your asynchronous method you need to await on it inside and not be eagerly calling the .Result property which of course is a blocking operation.

answered Jan 25, 2015 at 13:45

Darin Dimitrov

1.0m275 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Royi Namir Over a year ago

Where does it say that it contacts the QueryString part to the base address. Ive looked here but it says URI. but where is the officeal doc that says that it appends the QS to the base ? ( in GetAsync)

Darin Dimitrov Over a year ago

@RoyiNamir, I am not quite sure whether there's official documentation for this. Just look with Fiddler to know what happens under the covers and the exact HTTP request that gets sent.

Collectives™ on Stack Overflow

C# Web API call

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related