Cannot realloc c array of structs

Question

I have a structs like so

typedef struct ll_node {
    uint data;
    struct ll_node* next;
} ll_node;

typedef struct {
    ll_node* head;
    uint     count;
} linked_list;

typedef struct {
    linked_list* lists;
    uint list_size
} Context;

And I need to be able to have lists grow dynamically from context. Here is how I'm adding a linked list to my lists array

void add_list(Context* c) {
    if (c->list_size == 0) {
        c->lists = malloc(sizeof(linked_list));
    } else {
        realloc(c->lists, sizeof(linked_list) * (c->list_size + 1));
    }
    linked_list_init(c->lists[c->list_size]);
    list_size++;
}

The problem comes in whenever I realloc. I lose the data that is not the most current index in lists. So if c->lists[0] contained 1==>1==>2 then it would be gone and c->lists[1] would be initialized and ready for linked list functions.

Any help would be greatly appreciated

Iharob Al Asimi · Accepted Answer · 2015-01-04 16:39:06Z

4

this is wrong

realloc(c->lists, sizeof(linked_list) * (c->list_size + 1));

should be

c->lists = realloc(c->lists, sizeof(linked_list) * (c->list_size + 1));

and I would recommend a safe way of doing this

void *clists;

clists = realloc(c->lists, sizeof(linked_list) * (c->list_size + 1));
if (clists == NULL)
    handleCurrentErrorProbablyRetryOrAbortFillingTheListAndCleanupResources();
c->lists = clists

this way you wont overwrite the valid c->list in case of failure.

tip: don't update c->list_size unless the malloc or realloc was successful, you need to check that the return non-NULL.

edited Jan 4, 2015 at 16:39

answered Jan 4, 2015 at 16:17

Iharob Al Asimi

53.1k6 gold badges66 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Basile Starynkevitch Over a year ago

BTW, you should test against failure of malloc & realloc

Collectives™ on Stack Overflow

Cannot realloc c array of structs

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related