Angularjs binding not working when called from ng-click

Question

What am I doing wrong? search() works when called within the controller but not when called through ng-click="search()"

$scope.search = () => {
        $scope.getLocation()
            .then(location => xhr('/venues/search', { lat: location.lat, lng: location.lng, category: $scope.category }))
            .then(data => {
            $scope.venues = data;
            $scope.apply();

        });
    }

Did you mean to write $scope.$apply(), if so, that might be a problem given the fact that ng-click is handled within a $digest loop. — Vadim
– Vadim, Commented Nov 21, 2014 at 20:31
I found out the problem, the ng-click was not declared inside the controller, thanks @Vadim — Rony
– Rony, Commented Nov 21, 2014 at 20:51

basarat · Accepted Answer · 2014-11-21 21:27:48Z

3

Please do not put stuff directly on $scope. It is considered bad practice, suffers from accidental prototypal member overrides and defeats the purpose of using a class as a Controller.

These are covered in (disclaimer:my) video : https://www.youtube.com/watch?v=WdtVn_8K17E

answered Nov 21, 2014 at 21:27

basarat

278k60 gold badges475 silver badges528 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Angularjs binding not working when called from ng-click

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest