Trouble with javascript code

Question

I have javascript code:

function f_dialogOpen()
{
    var e_window = document.createElement("div");
    e_window.style.position = 'absolute';
    var n_width  = 300;
    var n_height = 200;
    var a_docSize = f_documentSize();
    e_window.style.left = ((a_docSize[0] - n_width)  / 2) + a_docSize[2]) + 'px';
    e_window.style.top  = ((a_docSize[1] - n_height) / 2) + a_docSize[3]) + 'px';
    e_window.style.zIndex = 1002;

    e_window.innerHTML = 'Hello, world!';

    document.body.appendChild(e_window);
}

Function f_documentSize() returns array[4] with widnow size. Here is what I get using firebug:

missing ; before statement
e_window.style.left = ((a_docSize[0] - n_width) / 2) + a_docSize[2]) + 'px';\n

What's wrong?

pheelicks · Accepted Answer · 2010-04-23 13:16:26Z

3

Wrong number of brackets:

e_window.style.left = ((a_docSize[0] - n_width)  / 2) + a_docSize[2]) + 'px';
e_window.style.top  = ((a_docSize[1] - n_height) / 2) + a_docSize[3]) + 'px';

You need:

e_window.style.left = (((a_docSize[0] - n_width)  / 2) + a_docSize[2]) + 'px';
e_window.style.top  = (((a_docSize[1] - n_height) / 2) + a_docSize[3]) + 'px';

answered Apr 23, 2010 at 13:16

pheelicks

7,4692 gold badges47 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tor Valamo Over a year ago

actually he may need 3, or it could concatenate instead of add.

Collectives™ on Stack Overflow

Trouble with javascript code

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest