Efficient way to handle big nested for loops to insert in db in android [duplicate]

Question

I have a huge data which i need to insert in sqlite database.

public synchronized void insert(ResponseModel[] response) {

    for (int i = 0; i < response.length; i++) { // Here response length is 100
        for (int j = 0; j < response[i].getPings().size(); j++) { // Here per response, ping size is around 300
            ContentValues cv = new ContentValues();
            if (response[i].getPings().get(j).getId() != null)
                cv.put(Constants.ID, response[i].getPings().get(j).getId().toString().trim());
            // More insertion code goes here
        }
    }
}

Now in this situation, the application takes too much time. The app doesn't hangs because it happens in a background thread. Is there any way to efficiently handle this huge looping?

At least you can move 'ContentValues cv = new ContentValues();' outside the loops and reuse it. — Ridcully
– Ridcully, Commented Oct 9, 2014 at 9:32
@RahulGupta, may I ask you to mark the answer as correct if it was useful for you and answers your question :) — Kiril Aleksandrov
– Kiril Aleksandrov, Commented Oct 30, 2014 at 7:37

Kiril Aleksandrov · Accepted Answer · 2014-10-09 09:51:53Z

Unfortunately Android SQLite API does not support bulk insertion. Although you can optimize the execution time by using a single transaction. By default Android uses a separate transaction for each insert() call. So in your scenario you will have 30000 transactions. Beginning and committing transactions is a time consuming operation. So you can use a single transaction for all the insertions:

try{
  db.beginTransaction();

  for (int i = 0; i < response.length; i++) { // Here response length is 100
    for (int j = 0; j < response[i].getPings().size(); j++) { // Here per response, ping size is around 300
      ContentValues cv = new ContentValues();
      if (response[i].getPings().get(j).getId() != null) {
        cv.put(Constants.ID, response[i].getPings().get(j).getId().toString().trim());
      }
      // More insertion code goes here
    }
  }

  db.setTransactionSuccessful();
} catch (SQLException e) {
  // Handle the exception...
} finally {
  db.endTranscation();
}

Collectives™ on Stack Overflow

Efficient way to handle big nested for loops to insert in db in android [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related