How to validate a checkbox input using PHP?

Question

I have two check boxes in my form:

<div class="label-input-wrapper pickup">    
        <div class="form-label">I need Airport pick-up</div>
        <div class="form-input">
            <input type="checkbox" name="pick_up" value="Yes" />Yes 
            <input type="checkbox" name="pick_up" value="No" />No
            <div class="error-msg">
                <?php if(isset($errors['pick_up_no'])) { echo '<span style="color: red">'.$errors['pick_up_no'].'</span>'; } ?>
            </div>
        </div>
</div>

Variable that saves the value of the above check boxes: $pickup = $_POST['pick_up'];

Validation:

//Check the airport pickup and make sure that it isn't a blank/empty string.
        if ($pickup == ""){
            //Blank string, add error to $errors array.        
            $errors['pick_up_no'] = "Please let us know your airport pick up requirement!";
        }       

        if (($pick_up = Yes) && ($pick_up = No)) {
            //if both selected, add error to $errors array.        
            $errors['pick_up_no'] = "Can not select Yes and No together!";
        }

But the above validation just printing Can not select Yes and No together! if both are NOT selected, or if only one selected or even both are selected. It gives same error message for all the selections. Why?

nop.. I just want to use check boxes only.. I like that name @Ghost — Riffaz Starr
– Riffaz Starr, Commented Sep 19, 2014 at 12:31
You should treat the values Yes and No as strings - so put quotes around them! — Allmighty
– Allmighty, Commented Sep 19, 2014 at 12:33
@Adimeus I've changed to if (($pick_up = "Yes") && ($pick_up = "No")) but still the result is same. — Riffaz Starr
– Riffaz Starr, Commented Sep 19, 2014 at 12:36
@RatanK I've updated with your code. Now it's showing proper error message if both are NOT selected. It's just not printing nothing if both selected. — Riffaz Starr
– Riffaz Starr, Commented Sep 19, 2014 at 12:38
@RiffazStarr Ghost's answer worked (for me). Thought you'd like to know, yet I still feel that radio buttons should be used instead. — Funk Forty Niner
– Funk Forty Niner, Commented Sep 19, 2014 at 14:17

Funk Forty Niner · Accepted Answer · 2014-09-19 13:49:11Z

3

You're presently assigning with a single = sign instead of comparing == with

if (($pick_up = Yes) && ($pick_up = No))

you need to change it to

if (($pick_up == "Yes") && ($pick_up == "No")){...}

while wrapping Yes and No inside quotes in order to be treated as a string.

Edit:

Your best bet is to use radio buttons, IMHO.

Using checkboxes while giving the user both Yes and No options shouldn't be used; it's confusing.

It should either be Yes OR No and not and.

<input type="radio" name="pick_up" value="Yes" />Yes 
<input type="radio" name="pick_up" value="No" />No

That is the most feasible solution.

edited Sep 19, 2014 at 13:49

answered Sep 19, 2014 at 12:40

Funk Forty Niner

74.2k14 gold badges71 silver badges146 bronze badges

Sign up to request clarification or add additional context in comments.

14 Comments

Riffaz Starr Over a year ago

I've updated to

if (($pick_up == "Yes") && ($pick_up == "No")) { 			//if both selected, add error to $errors array.         			$errors['pick_up_no'] = "Can not select Yes and No together!"; 		}

but it's just printing nothing if bot are selected..

Funk Forty Niner Over a year ago

I've made an edit with if (($pick_up == "Yes") || ($pick_up == "No")) try an OR operator @RiffazStarr or see Ghost's answer.

Funk Forty Niner Over a year ago

Plus, as Ghost states in his answer, you need to assign both checkboxes as name="pick_up[]" to be treated as an array. @RiffazStarr Did you try Ghost's answer in conjunction with mine?

Funk Forty Niner Over a year ago

@Ghost I've no more time to spend on this right now. OP would be better off using radio buttons, IMHO. Am not sure if OP tried yours. I'll have to come back later to see if I can make it work.

Riffaz Starr Over a year ago

Thanks for your all effort @Fred-ii- I changed check box to radio button as suggested. now it works fine. So I up voted your answer and accept his answer.

|

Kevin · Accepted Answer · 2014-09-19 12:52:54Z

2

I don't know why you need a checkbox for this (this is what radio button's are supposed to do), but you can do it something like:

if(!isset($_POST['pick_up']) || count($_POST['pick_up']) > 1) {
    echo 'please select at least 1 choice';
} else {
    echo $_POST['pick_up'][0];
}

Then make your checkbox names:

name="pick_up[]"

Or if you really need to have separate error messages. Do something like this:

$errors['pick_up_no'] = '';
if(!isset($_POST['pick_up'])) {
    $errors['pick_up_no'] = "Please let us know your airport pick up requirement!";
} elseif(count($_POST['pick_up']) > 1) {
    $errors['pick_up_no'] = "Can not select Yes and No together!"; // weird UX, should have prevented this with a radio button
}

if($errors['pick_up_no'] != '') {
    echo $errors['pick_up_no'];
} else {
    echo $_POST['pick_up'][0];
}

edited Sep 19, 2014 at 12:52

answered Sep 19, 2014 at 12:41

Kevin

41.9k12 gold badges57 silver badges72 bronze badges

4 Comments

Funk Forty Niner Over a year ago

I tend to think that this would work, although I haven't tested it yet. OP should give some input if it did or not. I'm right in the middle of something, so I'll come back later to let you know if it does, I will definitely +1 ;) yet I tend to think that radio buttons is a more feasible option as I've noted in my edit. Checkboxes for both yes AND no doesn't make sense, IMHO.

Kevin Over a year ago

@Fred-ii- yes actually i tested this before posting, but i also agree with your sentiment, this should be a radio button, no doubt, thats weird for a user experience to actually choose both yes and no

Funk Forty Niner Over a year ago

It's boils down to a "wishy washy" decision lol - It's yes or no. Pick me up at 8 and don't be late hahaha!

Kevin Over a year ago

@Fred-ii- well at heart, really my original answer is the one that utilizes the radio button which is most logical thing to use. anyway, hope the user tries this.

Ole Haugset · Accepted Answer · 2014-09-19 12:36:29Z

1

It is impossible for $_POST['pick_up'] to be both yes and no at the same time since the name is pick_up and not pick_up[] <- pointing to multiple variables. So it will either be yes or no either way because one parameter will overwrite the other. You would have to use javascript to verify only one is checked before submit in that case.

answered Sep 19, 2014 at 12:36

Ole Haugset

3,8053 gold badges27 silver badges48 bronze badges

2 Comments

Ratan K Over a year ago

Follow this and convert name of checkboxes pick_up[] and change like this if (($pick_up == 'Yes') && ($pick_up == 'No'))

Ole Haugset Over a year ago

Why the ** did i get downvoted on this. My answer is absolutely correct. As his code currently is, it is impossible for the _POST parameter to contain both yes and no at the same time.

sbrbot · Accepted Answer · 2014-09-19 13:28:01Z

1

Use array of checkbox field elements;

<input type="checkbox" name="pick_up[]" />Yes 
<input type="checkbox" name="pick_up[]" />No

then in your PHP script:

<?php

$pick_ups=$_POST['pick_up'];

$first=isset($pick_ups[0]); //true/false of first checkbox status
$second=isset($pick_ups[1]); //true/false of second checkbox status

?>

Again, as you've already been told, you should use radio-buttons for this purpose! Take into account that $_POST does not send checkbox if it is not set (check with isset($_POST['name'])

answered Sep 19, 2014 at 13:28

sbrbot

6,5257 gold badges49 silver badges83 bronze badges

Collectives™ on Stack Overflow

How to validate a checkbox input using PHP?

4 Answers 4

14 Comments

4 Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

14 Comments

4 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related