python file.write adding multiple lines in for loop

Question

In the following code the output adds each line 2 times

template_file = open("../conf/"+config_template_code+".tmpl",'r')
        config_out = open("../sites-enabled/"+domain_name+".conf",'w')
        for line in template_file:
                config_out.write(line.replace('CPANELIP',cpanel_ipv4))
                config_out.flush()
                config_out.write(line.replace('DOMAINNAME',domain_list))
                config_out.flush()
        template_file.close()
        config_out.close()

If i comment out one of the config_out.write it is fine; but I want 2 in place replacements in the file .

As a side note, flushing is an expensive operation and unneeded here. Just write and close (or use a with clause). Your data will get where it needs to go. — tdelaney
– tdelaney, Commented Sep 13, 2014 at 6:45

Zero Piraeus · Accepted Answer · 2014-09-13 06:38:03Z

3

You need to do the line.replace() twice, and the config_out.write() once:

                line = line.replace('CPANELIP',cpanel_ipv4)
                line = line.replace('DOMAINNAME',domain_list)
                config_out.write(line)
                config_out.flush()

answered Sep 13, 2014 at 6:38

Zero Piraeus

59.7k28 gold badges158 silver badges164 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

python file.write adding multiple lines in for loop

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related