Using Java enums with multiple parameters

Question

I'm using enums like below snippet and it is very helpful for me. However, when I want to define more than one ENUM (e.g. ENUM2, ENUM3), which have same parameters, I have to write everything that is tagged as "repeated code" in the snippet.

I'm thinking to encapsulate all parameters (p1, ...) within an object and just to give a reference to this object in the enum. However, this idea disturbs me since other extra instances will be generated.

Is the above approach is right, or how can solve this problem?

public enum ENUM1 {
    KEY_1(p1, p2, ..., pn),
    ...
    KEY_M(p1, p2, ..., pn);

    // constructor

    // REPEATED CODE
    private int p1, p2, ..., pn;
    public getP1();
    ...
    public getPM();
}

You could create an Enum containing the parameter set and getting passed to the second Enum - but then why having a second Enum at all? :-) — Smutje
– Smutje, Commented Aug 18, 2014 at 19:41
@Smutje: enums with identical parameters can still be useful, otherwise why have parameter-less enums? — Sean Van Gorder
– Sean Van Gorder, Commented Aug 18, 2014 at 20:03

Óscar López · Accepted Answer · 2014-08-18 19:49:51Z

2

Try this:

public enum ENUM1 {

    KEY_1(Arrays.asList(1, 2, 3)),
    KEY_2(Arrays.asList(4, 5, 6));

    ENUM1(List<Integer> ps) {
        params = Collections.unmodifiableList(ps);
    }

    private List<Integer> params;

    public int getP(int idx) {
        return params.get(idx);
    }

}

Given that you have several parameters of the same type, you could use a collection. Later, when you need to retrieve a particular parameter use the getP() method, just remember that the indexes are 0-based.

edited Aug 18, 2014 at 19:49

answered Aug 18, 2014 at 19:41

Óscar López

237k38 gold badges321 silver badges391 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Using Java enums with multiple parameters

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related