How do I get this class name via jQuery?

Question

Attempting to create an accordion, but I can't figure out to check if the wrapper has the active class.

My jQuery:

$('.faq_wrap span.plus').on(touchClick, function (e) {
    var topEl = $(this).closest('.faq_wrap');
    if (topEl.hasClass('active')) {
        topEl.removeClass('active');
        topEl.find('.answer').slideUp('fast');
        return false;
    }
    topEl.each(function (index, el) {
        topEl.removeClass('active');
        topEl.find('.answer').slideUp('fast');
    });
    topEl.find('.answer').slideDown('fast');
    topEl.addClass('active');
    console.log(topEl);
});

Here's the output from console.log:

enter image description here

I'm trying to check whether .faq_wrap.active already exists. If it does, slide the accordion up before sliding the new one down. As of right now, this check is ignored and I can open as many accordions at once as I want. Thoughts?

What does your HTML look like? You're logging topEl.children, but checking topEl.hasClass. What happens if you console.log(topEl);? — gen_Eric
– gen_Eric, Commented Jul 24, 2014 at 20:28
If there can only ever be one .active piece, why not simply do if ($('.faq_wrap.active')) { ... rest of code? Wondering why you only check the closest .faq_wrap too. — webketje
– webketje, Commented Jul 24, 2014 at 20:30
@YuliamChandra touchClick is just a click variable I have set since I'm working with mobile devices. — itsclarke
– itsclarke, Commented Jul 24, 2014 at 20:33

idmean · Accepted Answer · 2014-07-24 20:45:18Z

1

Use .get()

topEl.get(0).className

edited Jul 24, 2014 at 20:45

answered Jul 24, 2014 at 20:34

idmean

15k9 gold badges63 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

itsclarke Over a year ago

Can that be changed to getting the full div? Just so I can check if it has class active or not.

idmean Over a year ago

Sure, just use topEl.get(0)

itsclarke Over a year ago

okay, another question (sorry im dumb): why do i get undefined is not a function when i swap the following in, on my 2nd line: var topEl = $(this).closest('.faq_wrap').get(0);

idmean Over a year ago

Because then the element is no longer a jQuery object but a plain JavaScript DOM object, and on this you can't call methods like .hasClassor .each.

webketje · Accepted Answer · 2014-07-24 20:58:23Z

You have multiple collapsible/ expandable sections in your HTML, from which only one is ever going to be active (expanded). You use .closest() but if there's only one you could just as well use the direct class selector .faq_wrap.active (it will return either 0 or 1 element, depending on whether the user has already clicked). There's also no point in doing topEl.each because .closest() will return only the closest node (here, the parent). So the following should be better ( & more concise)

$('.faq_wrap span.plus').on(touchClick, function (e) {
    var topEl = $(this).closest('.faq_wrap'),
        activeEl = $('.faq_wrap.active');

    if (activeEl.length) { // implied: if it's bigger than 0
        activeEl.removeClass('active');
        activeEl.find('.answer').slideUp('fast');
    }
    topEl.find('.answer').slideDown('fast');
    topEl.addClass('active');
});

NB: Just wondering, why did you use the return false; statement?

Collectives™ on Stack Overflow

How do I get this class name via jQuery?

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related