How can I access a variable in a javascript function from the rest of the script?

Question

My function is the call that is made by the onchange event in an html select type input. I assign a variable that value, but it doesn't seem to get accessed by a variable of the same name outside that function, say, in $(document).ready()

<select form="submitForm" name="frequency" class="meal-type-select" onchange="getFreqVal(this)">
        <option value="O">One Time</option>
        <option value="D">Daily</option>
        <option value="W">Weekly</option>
        <option value="M">Monthly</option>
        <option value="Y">Yearly</option>
        <option value="R">Requested</option>
</select>

And the script is this: (There is a lot more to the script, but I've only shown the part relevant to the question, to make it less clattered)

<script>
$(document).ready(function() {

    var freqVal;


    $('#addPictures').click(function() {

        alert(freqVal);

    });

});

function getFreqVal(sel)
{
    freqVal =   sel.value;
    alert(freqVal);
}
</script>

Move the var freqVal; out of the document ready function.. to start of the script block.. — Hardy
– Hardy, Commented Jul 13, 2014 at 22:39

darrenb · Accepted Answer · 2014-07-13 22:41:51Z

2

Just declare freqVal outside $(document).ready(). They're two different functions, essentially.

answered Jul 13, 2014 at 22:41

darrenb

1113 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

darrenb Over a year ago

Just fyi, by two different functions, I mean $(document).ready() and getFreqVal

GothamCityRises Over a year ago

Yes i understood that.

muuk · Accepted Answer · 2014-07-13 22:39:20Z

2

the variable freqval is outside the scope of getFeqVal(). This is what you should do:

<script>
    var freqVal;
    $(document).ready(function() {

        $('#addPictures').click(function() {

            alert(freqVal);

        });

    });

    function getFreqVal(sel)
    {
        freqVal =   sel.value;
        alert(freqVal);
    }
</script>

This makes the scope of freqVal global.

answered Jul 13, 2014 at 22:39

muuk

9321 gold badge7 silver badges15 bronze badges

Comments

MightyPork · Accepted Answer · 2014-07-13 22:38:26Z

1

You are declaring your variable inside the function, so it won't be visible outside the function scope. The way you do it, both the functions have their own variable named freqVal.

You can use a global variable (member of window):

<script>

var freqVal; // here

$(document).ready(function() {
    $('#addPictures').click(function() {
        alert(freqVal);
    });
});

function getFreqVal(sel)
{
    freqVal = sel.value;
    alert(freqVal);
}

</script>

answered Jul 13, 2014 at 22:38

MightyPork

19k10 gold badges87 silver badges136 bronze badges

Comments

adeneo · Accepted Answer · 2014-07-13 22:46:59Z

1

Remove the inline javascript and use jQuery

$(document).ready(function() {

    $('.meal-type-select').on('change', function() {

        // stuff on select change

    });

    $('#addPictures').on('click', function() {

        var freqVal = $('.meal-type-select').val();

    });
});

answered Jul 13, 2014 at 22:46

adeneo

319k29 gold badges410 silver badges392 bronze badges

Collectives™ on Stack Overflow

How can I access a variable in a javascript function from the rest of the script?

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related