Python - Store strings from text file into a variable

Question

I'm wanting a script that will store the first word from each line from an input file into a variable.

Current code only stores the last name.

def func(file): 
  global user 
  with open(file) as iFile: 
    for line in iFile: 
    string = line.split(',') 
    user = string[0]

func(sys.argv[1]) 
print user

The text file input is:

string1,string2,string3
string1,string2,string3
string1,string2,string3

I want the variable user to store the all of the string1's on each line from the text file.

Your indentation is incorrect, you may want to correct that. Next, you are confusing user and username in your code. Last but not least, did you want a list of strings perhaps? — Martijn Pieters
– Martijn Pieters, Commented Jul 8, 2014 at 10:10
Sorry, corrected the 'user' and 'username'. Yes, a list would work. Not too sure though, hehe. New to this. — Eric1989
– Eric1989, Commented Jul 8, 2014 at 10:13

PsyKzz · Accepted Answer · 2014-07-08 10:15:48Z

1

Indenting issue.

This will fix it. I also changed your func, so that you no longer use a global but instead return a generator with the users from the list.

This is a better practise and more memory efficient.

def func(file): 
  with open(file) as iFile: 
    for line in iFile: 
        string = line.split(',') 
        yield string[0]

for user in func(sys.argv[1]) 
    print user

answered Jul 8, 2014 at 10:15

PsyKzz

7404 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Angry Cat · Accepted Answer · 2014-07-08 10:21:40Z

1

i recommend this

def func(path):
    with open(path) as _file:
        return [s.split(',')[0] for s in _file]

user = func(sys.argv[1])
print user

answered Jul 8, 2014 at 10:21

Angry Cat

2511 silver badge6 bronze badges

Comments

Jerome · Accepted Answer · 2014-07-08 10:16:46Z

0

I would go for this :

user = []
def func(file): 
  with open(file) as iFile: 
    for line in iFile: 
      user.append(line.split(',')[0])

func(sys.argv[1]) 
print user

It stores in a list all "first string" of every line you will provide to the function. By the way the solution of Matt PsyK is totally more efficient!

answered Jul 8, 2014 at 10:16

Jerome

1,2152 gold badges12 silver badges23 bronze badges

Collectives™ on Stack Overflow

Python - Store strings from text file into a variable

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related