Hide element by class (only Javascript, no Jquery)

Question

I would like to hide Elements by class name. I found a working example that runs outside of a function. However, when I use onClick it doesn't seem to work anymore. Please take a look at the following example: http://jsfiddle.net/SkfDz/9/ Can anyone please help me?

HTML:

<input class="" name="options" id="opt1" type="radio" onClick="hideToday()"/><label for="opt1">Hide today</label>
<input class="" name="options" id="opt1" type="radio" onClick="hideToday()"/><label for="opt1">Hide today</label>

<div class="today">TODAY</div>
<div class="today">TODAY</div>
<div class="today">TODAY</div>

<div class="tomorrow">TOMORROW</div>

Script:

function hideToday() {
    var todayElements = document.getElementsByClassName('today'), i;
    for (i = 0; i < todayElements.length; i += 1) {
    todayElements[i].style.display = 'none';
    };
};

var tomorrowElements = document.getElementsByClassName('tomorrow'), i;
for (i = 0; i < tomorrowElements.length; i += 1) {
    tomorrowElements[i].style.display = 'none';
}

You could do this more simply and quickly with CSS.

Pointy
– Pointy

2014-07-02 13:13:44 +00:00
Commented Jul 2, 2014 at 13:13 — Pointy
– Pointy, Commented Jul 2, 2014 at 13:13

spender · Accepted Answer · 2014-07-02 13:17:14Z

1

The reason it doesn't work in jsfiddle is that your hideToday function is out of scope. I don't know which scope the script in jsfiddle exists, but it seems it isn't global.

If you put the same code in a webpage and view it, it works as expected:

<html>
<body>
    <input class="" name="options" id="opt1" type="radio" onClick="hideToday()"/><label for="opt1">Hide today</label>
    <input class="" name="options" id="opt1" type="radio" onClick="hideToday()"/><label for="opt1">Hide today</label>
    <br>
    <br>
    <div class="today">TODAY</div>
    <div class="today">TODAY</div>
    <div class="today">TODAY</div>
    <br>
    <div class="tomorrow">TOMORROW</div>
    <script>
        function hideToday() {
            var todayElements = document.getElementsByClassName('today'), i;
            for (i = 0; i < todayElements.length; i += 1) {
            todayElements[i].style.display = 'none';
            };
        };

        var appBanners = document.getElementsByClassName('tomorrow'), i;
        for (i = 0; i < appBanners.length; i += 1) {
            appBanners[i].style.display = 'none';
        }
    </script>
</body>
</html>

You can fix your fiddle by exporting hideToday onto window:

window["hideToday"] = hideToday;

http://jsfiddle.net/SkfDz/16/

answered Jul 2, 2014 at 13:17

spender

121k36 gold badges245 silver badges369 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pointy Over a year ago

The jsfiddle controls allow you to tell it to wrap the code typed in the lower left quadrant in a window "load" handler. It's also possible to tell it not to do that.

Laurent S. · Accepted Answer · 2014-07-02 13:15:53Z

0

If you want to use the onClick that way, which is a bad idea, you need to put your javascript in you Head, so you can make your fiddle work just by changing the second select box on top left to No wrap - in <head> But it would be better to not use inline javascript and put event handling in external file too.

answered Jul 2, 2014 at 13:15

Laurent S.

6,9373 gold badges32 silver badges42 bronze badges

Collectives™ on Stack Overflow

Hide element by class (only Javascript, no Jquery)

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related