node module gitignores its own node_modules directory, breaking Heroku deploy

Question

I'm using the aws-sdk module, which has a .gitignore file that ignores its own node_modules directories, breaking my Heroku deployment.

Is there a proper way to deal with this sort of situation? When I heroku bash I see that the dependencies are missing from aws-sdk it has no node_modules directory.

Are you checking in node_modules as part of your git project? — SomeKittens
– SomeKittens, Commented May 26, 2014 at 6:52
@SomeKittensUx2666 always do. my temporary fix is to remove the .gitignore from aws-sdk module. Seems strange that such a popular module wouldn't work out of the box on Heroku though... — o_o_o--
– o_o_o--, Commented May 26, 2014 at 17:51
Generally speaking, us Nodeists on Heroku don't check in node_modules (npm shrinkwrap is just as good, and is much smaller). — SomeKittens
– SomeKittens, Commented May 26, 2014 at 17:53

SomeKittens · Accepted Answer · 2014-05-26 17:56:11Z

1

Typically, Heroku will run npm install for you after each deploy, but only if the node_modules folder is not already present.

You have two major options:

Stop checking in node_modules and switch to npm shrinkwrap to keep exact versions
Remove .gitignore from aws-sdk (not recommended, as you're modifying packages)

I suggest the first, as it allows you to keep the functionality checking in node_modules gives you, without losing anything or modifying other's packages.

answered May 26, 2014 at 17:56

SomeKittens

39.6k19 gold badges117 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

basarat · Accepted Answer · 2014-05-26 04:55:10Z

0

A simple npm install as a part of your deployment script should take care of it for you assuming that you are listing aws-sdk as a dependency in your package.json.

answered May 26, 2014 at 4:55

basarat

278k60 gold badges475 silver badges528 bronze badges

2 Comments

o_o_o-- Over a year ago

I'll try this next time I have access. I was under the impression that Heroku atuomatically npm-installs on every deploy?

basarat Over a year ago

Even if it does, it only does it at the root level

Collectives™ on Stack Overflow

node module gitignores its own node_modules directory, breaking Heroku deploy

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related