"Uncaught TypeError: object is not a function" Error in javascript

Question

I am having a small problem. I want to display a slideshow, but the images are not moving. When I check it in the console I get the error

Uncaught TypeError: object is not a function

Can someone please help me?

Here's my javascript code:

        var step=1;
 var images = [
"5c.jpg",
"5s.jpg",
"a65.jpg"

];

var slideshow = document.getElementById('slideshow');

 function slide(){   
    slideshow.src = images[step];
    if(step<3){
        step++;
    }
    else
        step=1;
    setTimeout("slide()",2500); 
 }

and my html file:

<html>
    <body>
        <img src="C:\Users\M.OAN\Desktop\Pics\Slideshow\5c.jpg" alt="images" name="slide" id="slideshow" onload="slide();"/>     
    </body>
</html>

thanks for the advice but can u tell me why i m getting this error :/ — Decisive Reason
– Decisive Reason, Commented May 10, 2014 at 20:00

Artem Petrosian · Accepted Answer · 2014-05-10 20:37:02Z

1

You can make Array with your image paths and then just iterate thru it:

HTML:

<img id="slideshow" src="http://placekitten.com/50/50" alt="images" name="slide"/>

JS:

var images = [
    "http://placekitten.com/100/100",
    "http://placekitten.com/100/50",
    "http://placekitten.com/50/100"
];

// get image element
var slideshow = document.getElementById('slideshow');

// in arrays index starts from 0
var step = 0;

setInterval(function(){

    slideshow.src = images[step];

    if( step < images.length-1 ){
        step++;
    } else {
        step = 0;
    }    

}, 2500 );

Demo fiddle

Btw, I recommend you to use relative paths instead of absolute, because you may have problems when you try deploy your site:

"Pics/Slideshow/5c.jpg"

instead of

"C:/Users/M.OAN/Desktop/Pics/Slideshow/5c.jpg"

edited May 10, 2014 at 20:37

answered May 10, 2014 at 20:06

Artem Petrosian

2,9541 gold badge24 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

Artem Petrosian Over a year ago

@Ejay of course not, I'm just try to solve the first problem, I've added recommendation about source too.

Decisive Reason Over a year ago

and i should probably tell u one thing that it was working perfectly when i was calling slide mthod from onload event in body tag but i had to remove it from there for some reasons

Artem Petrosian Over a year ago

@user3624126 Try fiddle demo that I've inserted above

Decisive Reason Over a year ago

it works but i m having the same problem i suffered from when i used onload in body tag, the slideshow starts right at the header but i want the image src to change in the image tag , that's why i specifically called the onload in img tag so the images will be changed there not in header

Artem Petrosian Over a year ago

@user3624126 I'm not sure that I understand exactly what you try to explain, but if you want to get specific element in DOM, just use document.getElementById('elementID') function.

|

yosahr · Accepted Answer · 2014-05-10 21:16:53Z

0

From Fiddling a bit, the source of the original error was that the name of the tag and the function were the same.

answered May 10, 2014 at 21:16

yosahr

141 bronze badge

1 Comment

Pawan Rai Over a year ago

you should post it in comments .

Collectives™ on Stack Overflow

"Uncaught TypeError: object is not a function" Error in javascript

2 Answers 2

11 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

11 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related