Visual Studio 2013 JavaScript/TypeScript odd indenting behavior

Question

When working on my TypeScript code there is an issue with the automatic indenting of code. I use VS2013 with Resharper.

The problem occurs mostly from method chaining.

For example using promises:

someService.GetSomeProperties().then(x => {
    return otherService.doSomethingWithX(x.map(y => y.id));
}).then(x => {
    // Pressing enter sets the cursor to this position
        // Using document format (CTRL+K,CTRL+D) the code moves to this level
        return '';
}).then(x => { // Pressing enter from here
    // Moves the previous line to it's position and cursor here
    return 'a';
    }).then(x => {
        // However document format moves this code block to this indention level
        // as well
    }).then(x => {
        // Follow up chaining remains the same
    });

Based on the 'symptoms' this behavior seems to be coming from having multi-line statements in general.

I've looked through both VS2013's options and R#s but I can't find any option that has any effect on this behavior.

Does anybody know how to fix it?

I suggest filing a bug report.

Ingo Bürk
– Ingo Bürk

2014-04-21 14:13:49 +00:00
Commented Apr 21, 2014 at 14:13 — Ingo Bürk
– Ingo Bürk, Commented Apr 21, 2014 at 14:13

basarat · Accepted Answer · 2014-04-22 12:50:14Z

2

Does anybody know how to fix it?

It is fixed if you put then in a new line (i.e. each top level function gets its own line) and always use semicolons:

someService.GetSomeProperties()
    .then(x => {
        return otherService.doSomethingWithX(x.map(y => y.id));
    })
    .then(x => {
        // Pressing enter sets the cursor to this position
        // Using document format (CTRL+K,CTRL+D) the code moves to this level
        return '';
    })
    .then(x => { // Pressing enter from here
        // Moves the previous line to it's position and cursor here
        return 'a';
    })
    .then(x => {
        // However document format moves this code block to this indention level
        // as well
    })
    .then(x => {
        // Follow up chaining remains the same
    });

edited Apr 22, 2014 at 12:50

answered Apr 22, 2014 at 1:56

basarat

278k60 gold badges475 silver badges528 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Aidiakapi Over a year ago

How is this an answer to my question? Who recommends this style? AFAIK style is a matter of preference, I agree on the semicolons (and am wondering where you see any missing ones), but the then on a new line is is the same as people arguing whether you should write an else statement as } else { or with a newline } \n else {.

Aidiakapi Over a year ago

Semicolons are not just style, they can influence behavior, if they were solely used for aesthetic purposes I couldn't care less which one someone uses, as long as they're consistent about it. For example in Lua they're purely a matter of style, and can always be replaced with a space (except of course in string literals). .then on the other hand is unaffected whether you put it on the same line or the next one, so that's just style.

Ingo Bürk Over a year ago

I agree with @Aidiakapi. Semicolons are widely considered "mandatory" even if in theory mostly optional. Putting then on a new line certainly is a matter of style, but if switching IDE is not an option, I'd prefer this over broken formatting – at least it's consistent and makes sense (unlike broken indentation).

Collectives™ on Stack Overflow

Visual Studio 2013 JavaScript/TypeScript odd indenting behavior

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related