Binding Issue in WPF

Question

I have problem with binding, I'm trying to move rectangle when mouse is moved, this is my list:

    <ListBox x:Name="icTables" FlowDirection="LeftToRight" ItemsSource="{Binding Path=ocTablesinSection,UpdateSourceTrigger=PropertyChanged}" Margin="0,101,52,0" Grid.Column="1" SelectionMode="Extended" HorizontalAlignment="Right" Width="705" Height="400" VerticalAlignment="Top">
        <ListBox.ItemsPanel>
            <ItemsPanelTemplate>
                <Canvas/>
            </ItemsPanelTemplate>
        </ListBox.ItemsPanel>
        <ItemsControl.ItemContainerStyle>
            <Style
                TargetType="ListBoxItem">
                <Setter Property="Canvas.Left" Value="{Binding Path=CLeft,UpdateSourceTrigger=PropertyChanged}"/>
                <Setter Property="Canvas.Top" Value="{Binding Path=CTop,UpdateSourceTrigger=PropertyChanged}"/>
            </Style>
        </ItemsControl.ItemContainerStyle>
        <ListBox.ItemTemplate>
            <DataTemplate>
                <Grid>
                    <Rectangle Width="50" Height="50" Fill="Red" Cursor="Hand" MouseDown="Rectangle_MouseDown" MouseUp="Rectangle_MouseUp" MouseMove="Rectangle_MouseMove" />
                </Grid>
            </DataTemplate>
        </ListBox.ItemTemplate>
    </ListBox>

In MouseMove event in code behind:

        private void Rectangle_MouseMove(object sender, MouseEventArgs e)
    {
        if (isDraggingRectangle)
        {
            //
            // Drag-move selected rectangles.
            //
            Point curMouseDownPoint = e.GetPosition(this);
            var dragDelta = curMouseDownPoint - origMouseDownPoint;

            origMouseDownPoint = curMouseDownPoint;

            foreach (var item in ocTablesinSection)
            {
                item.CLeft += dragDelta.X;
                item.CTop += dragDelta.Y;
            }
       }
        else if (isLeftMouseDownOnRectangle)
        {
            //
            // The user is left-dragging the rectangle,
            // but don't initiate the drag operation until
            // the mouse cursor has moved more than the threshold value.
            //
            Point curMouseDownPoint = e.GetPosition(this);
            var dragDelta = curMouseDownPoint - origMouseDownPoint;
            double dragDistance = Math.Abs(dragDelta.Length);
            if (dragDistance > DragThreshold)
            {
                //
                // When the mouse has been dragged more than the threshold value commence dragging the rectangle.
                //
                isDraggingRectangle = true;
            }

            e.Handled = true;
        }
    }

Every thing works but the UI don't show updated (Rectangle do not move), When I change CLeft and CTop to a public variable and the window as Element-name it works !!

What is the problem in my code the prevent the rectangle from moving with mouse?

// Update --

private ObservableCollection<TablesinSection> _ocTablesinSection;

public ObservableCollection ocTablesinSection { get { return _ocTablesinSection; } set { _ocTablesinSection = value; OnPropertyChanged("ocTablesinSection"); } }

When I change CLeft and CTop to a public variable and the window as Element-name it works !! - What do you mean by this? Post code for CLeft and CTop. — Rohit Vats
– Rohit Vats, Commented Apr 19, 2014 at 14:58
@Rohit Vats ocTablesinSection is an Observable Collection of Resturant tables, CLeft and CTop is an fields in each record that describe location of each table, instead of using CLeft and CTop if I had defined a Public variable and bind it to Canvas it works. hope this clear. — Abdulsalam Elsharif
– Abdulsalam Elsharif, Commented Apr 19, 2014 at 15:05

Rohit Vats · Accepted Answer · 2014-04-19 15:44:02Z

2

WPF bindings doesn't work with fields. It works only with properties.

Declare them as properties.

public double CLeft { get; set; }
public double CTop { get; set; }

Also in case you want to update UI on any property change, you have to implement INotifyPropertyChanged interface on class containing this property.

UPDATE

Make properties to raise PropertyChangedEvent:

private double cLeft;
public double CLeft
{
   get
   {
      return cLeft;
   }
   set
   {
      if(cLeft != value)
      {
         cLeft = value;
         OnPropertyChanged("CLeft");
      }
   }
}

Do this same for CTop as well.

edited Apr 19, 2014 at 15:44

answered Apr 19, 2014 at 15:08

Rohit Vats

81.5k13 gold badges170 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Abdulsalam Elsharif Over a year ago

Thanls for your time, But CLeft and CTop each one is a property in TablesinSection class that defined in my project Model, It should work or I'm wrong?

Rohit Vats Over a year ago

Under comments section you mentioned those were fields. Anyhow if they are properties, have you raise PropertyChangedEvent whenever those values gets set. TablesinSection should implement INPC like mentioned above.

Abdulsalam Elsharif Over a year ago

Yes I have implemented INPC as: private ObservableCollection<TablesinSection> _ocTablesinSection; public ObservableCollection<TablesinSection> ocTablesinSection { get { return _ocTablesinSection; } set { _ocTablesinSection = value; OnPropertyChanged("ocTablesinSection"); } }

Rohit Vats Over a year ago

Make CLeft and CTop to follow the same syntax.

Collectives™ on Stack Overflow

Binding Issue in WPF

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related