PHP function does not execute

Question

I am attempting to call a class function from address bar as follows:

http://localhost:82/spam_fetcher.php?rm=index

My script is:

  class Spam_fetcher{
    public function __construct()
    {
        if (isset($_GET['rm']) && method_exists('Spam_fetcher', $_GET['rm'])) {
            $view = new Spam_fetcher();
            $view->$_GET['rm']();
        }
        else
        {
            echo "No such a function";
        }
    }

    public function index()
    {
        echo 'something';
    }
}

But index function does not execute. What do you guys think I am doing something wrong here?

Wrong place: you didn't show your code & where did you call your method — Alma Do
– Alma Do, Commented Apr 7, 2014 at 12:13
You just define a class, there's nothing actually instantiating or calling it (as far as we can see). — deceze
– deceze ♦, Commented Apr 7, 2014 at 12:15
I'd like to call index() and echo out 'something' what is your suggestion? — curiozity
– curiozity, Commented Apr 7, 2014 at 12:16

Unstaged · Accepted Answer · 2014-04-07 12:21:56Z

2

class Spam_fetcher{
    public function __construct()
    {
        if (isset($_GET['rm']) && method_exists($this, $_GET['rm'])) {
           $this->$_GET['rm']();
        }
        else
        {
            echo "No such a function";
        }
    }

    public function index()
    {
        echo 'something';
    }
}

$view = new Spam_fetcher();

answered Apr 7, 2014 at 12:21

Unstaged

5092 gold badges5 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Shankar Narayana Damodaran Over a year ago

+1 , You should also explain the changes done on your code like adding $this , created a new instance, removed the new Spam_fetcher();.. etc.

DarkSide Over a year ago

$this->$_GET['rm'](); possible code injection. Never ever do like this without checking user input first or at least escaping it.

Collectives™ on Stack Overflow

PHP function does not execute

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related