PHP javascript function...simpler way?

Question

The javascript countdown code I am using requires me to use this format: "year, month - 1, day, hour, minute, second". I have the following code, which works, but I'm wondering if there's a simpler method of getting it to work (one with less lines, one that might be quicker?)

$year = date('Y',$date);
$month = date('n',$date);
$day = date('j',$date);
$hour = date('g',$date);
$minute = date('i',$date);
$second = date('s',$date);
$js .= "var newYear = new Date();
        newYear = new Date(".$year.", ".$month." - 1, ".$day.", ".$hour.", ".$minute.", ".$second.");
        $('#timer').countdown({
            until: newYear,
            layout: '{hn} h {mn} m {sn} s'
        });";

@Dagon Well, some PHP is needed, to transport the variable $date, which has presumably been calculated elsewhere, into an appropriate JS value. — IMSoP
– IMSoP, Commented Apr 3, 2014 at 22:33
Using the date function six times and then concocting the results is unnecessary, to do it all with one date function call: date("Y, n, y, g, i, s", $date). — Jasper
– Jasper, Commented Apr 3, 2014 at 23:08

Kristopher Ives · Accepted Answer · 2014-04-03 22:54:41Z

1

You should avoid generating Javascript via PHP. Your Javascript code should not change per-user or per page render, and you should simply include it from a static file. Any data should be accessed over Ajax or stored locally in that page via a DOM node:

<input type="hidden" id="someAppData" value="1242525242"/>
$(function () {
    // Grab the data from the DOM node
    var newYear = $('#someAppData').val();

    $('#timer').countdown({
        until: newYear,
        layout: '{hn} h {mn} m {sn} s'
    });
});

answered Apr 3, 2014 at 22:54

Kristopher Ives

6,1058 gold badges46 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jasper Over a year ago

This way you can include an external JS file and not have to worry about making your web server parse .js files with the PHP interpreter.

Community · Accepted Answer · 2017-05-23 10:26:03Z

0

You don't need any PHP code for this besides passing along the $date value to your HTML page. Consider passing over a timestamp value.

HTML/(PHP >5.2.0) Code:

<script>
    var newYear = new Date(<?= (new DateTime($date))->getTimestamp() * 1000 ?>);
    $('#timer').countdown({
        until: newYear,
        layout: '{hn} h {mn} m {sn} s'
    });";
</script>

Basically you're passing over the timestamp from PHP (in seconds) to your Javascript (in milliseconds) into their respective Date objects. If you don't have short tags enabled, you can replace what's in the angle brackets with <?php echo (new DateTime($date))->getTimestamp() * 1000; ?>

edited May 23, 2017 at 10:26

CommunityBot

11 silver badge

answered Apr 3, 2014 at 22:49

Sunny Patel

8,0972 gold badges35 silver badges47 bronze badges

4 Comments

Niet the Dark Absol Over a year ago

Why (new DateTime($date))->getTimestamp() * 1000 when you could just do time()*1000?

Sunny Patel Over a year ago

OP didn't ask for current time. This could be a value that's been passed in through a form or query string.

Niet the Dark Absol Over a year ago

strtotime($date) then ;)

Sunny Patel Over a year ago

Whiehever, I figure that this would be most accurate, and respective to timezones if done right.

Collectives™ on Stack Overflow

PHP javascript function...simpler way?

2 Answers 2

1 Comment

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related