Return hgetall list from redis in nodejs

Question

I'm trying to return a json object so that I can pass it back before a page is rendered to populate a list. My problem is that I can't figure out how to pass the object data out from the hgetall callback function. Here is my example with comments on what I'm missing:

var redis = require("redis"),
    client = redis.createClient();

function createMobs() {

    var mobObject = {
        name: "Globlin",
        hp: 12,
        level: 1
    };
    client.hmset("monsterlist", "mobs", JSON.stringify(mobObject));

    var myMobs = function(object) {
        return object;
    };

    var getMobs = function(callback) {   
      client.hgetall("monsterlist", function(err, object) {
        callback(object);
      });    
    };

    // This is returning undefined instead of my mob
    console.log("mobs: ", getMobs(myMobs));

    // Goal is to return moblist
    // return getMobs(myMobs);

}

exports.createMobs = createMobs;

ZachRabbit · Accepted Answer · 2014-03-01 05:09:49Z

6

The short answer is that you're not thinking asynchronously. Because you're using asynchronous functions in your function, your function must also be asynchronous.

Since you didn't post the rest of your code, here's the basic idea:

var client = require('redis').createClient();

function createMobs(callback) {
    var mobObject = { name: 'Goblin' };

    client.hmset('monsterlist', 'mobs', JSON.stringify(mobObject), function(err) {
        // Now that we're in here, assuming no error, the set has went through.

        client.hgetall('monsterlist', function(err, object) {
            // We've got our object!

            callback(object);
        });

        // There is no way to run code right here and have it access the object variable, as it would run right away, and redis hasn't had time to send you the data yet. Your myMobs function wouldn't work either, because it is returning a totally different function.
    });
};

app.get('/create', function(req, res) {
    createMobs(function(object) {
        res.render('mobs.jade', {
            mobs: object
        });
    });
});

Hopefully that helps clear things up.

answered Mar 1, 2014 at 5:09

ZachRabbit

5,1841 gold badge26 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Organiccat Over a year ago

Thanks, it does, I was trying to just return the object, which was my problem, rather than DOING something at the time of the finished action.

sb39 · Accepted Answer · 2019-10-15 19:08:05Z

2

The only way to deal with hgetall returning value are by Promises.

get all function:

 async hashget(tag) {
        return new Promise((resolve, reject) => {
          redis.createClient({ port: portnumber, host: config.redis.host 
           }).hgetall(tag, (err, object) => {
            if (err) {
              reject(err);
            } else {
              resolve(Object.keys(object));
            }
          });
        });
      }

and handle it in the through the promise as

const result = await this.redis.hashget('asize').then((result) => {
        return result;
 });
return result;

answered Oct 15, 2019 at 19:08

sb39

1012 silver badges9 bronze badges

Comments

Woppi · Accepted Answer · 2019-01-14 09:46:46Z

I also encountered similar issue wherein I would need the result of hgetall back the function calling it. Here is how I got it working on my end.

export const test = async (hashId) => {
  // reachedLimit will have value after the hgetall result on the `monitorLimit` function
  const reachedLimit = await monitorLimit(hashId);
}

export const monitorLimit = (hashId) => {
  let reachedLimit = false;
  let attempts = 0;

  return new Promise((resolve, reject) => redisDB.hgetall(hashId, (err, result) => {
    if (err) {
      // TODO reject logic here...
    }

    if (result) {
      attempts = Number(result.tries);

      if (attempts === 3) {
        reachedLimit = true;
        resolve({ reachedLimit });
      }
    }

    attempts += 1;

    redisDB.hmset(hashId, ['tries', attempts], (createErr) => {
      if (createErr) {
        // TODO reject logic here...
      }
    });

    // expire in 3 minutes
    redisDB.expire(hashId, 180);
    resolve({ reachedLimit });
  }));
};

suraj gholap · Accepted Answer · 2020-09-04 11:51:39Z

0

my solution for this error SyntaxError: Unexpected token o in JSON at position 1

res.send(Object.values(JSON.parse(JSON.stringify(object))))

answered Sep 4, 2020 at 11:51

suraj gholap

4176 silver badges3 bronze badges

Collectives™ on Stack Overflow

Return hgetall list from redis in nodejs

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related