Use of static objects in asp.net

Question

I am using the followign object in my asp.net page

private static Dictionary<string, List<Guid>> OpenNodes = new Dictionary<string,    List<Guid>>();  
//Page start
if(!OpenNodes.ContainsKey(Session.SessionID))  
{  
    List<Guid> list = new List<Guid>();  
    OpenNodes.Add(Session.SessionID, list);  
}

//User clicked on a node
Guid id = new Guid(e.Node.Value);  
tmpList = OpenNodes[Session.SessionID];  
tmpList.Add(id);  
OpenNodes[Session.SessionID] = tmpList;

Is it agood practive or is there a similar 'better' way to achieve the same?

i miss locks ... either lock(/**/) or ReaderWriterLockSlim-usage — user57508
– user57508, Commented Feb 5, 2010 at 10:19

Mehrdad Afshari · Accepted Answer · 2010-02-05 10:18:16Z

7

You should not replace Session with static fields. Session is much more flexible and less error-prone. You can easily make it work in Web farms (you can't do that with static fields). You can consider replacing some Application variables with static fields. It's important to know that static fields don't provide any thread safety mechanism out of the box and you should manually control (lock) them appropriately.

answered Feb 5, 2010 at 10:18

Mehrdad Afshari

424k93 gold badges864 silver badges796 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arve · Accepted Answer · 2010-02-05 10:17:59Z

4

A web server is multi threaded. You need to synchronize access to shared/static objects

answered Feb 5, 2010 at 10:17

Arve

7,5245 gold badges40 silver badges44 bronze badges

Comments

GvS · Accepted Answer · 2010-02-05 10:22:31Z

3

In this case, you can just use the Session state. I see no pro's in using the pattern you propose here.

If you really need to mimic some static field. You should use the Application state.

answered Feb 5, 2010 at 10:22

GvS

52.5k16 gold badges104 silver badges139 bronze badges

Collectives™ on Stack Overflow

Use of static objects in asp.net

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related