passing parameter to javascript onclick function

Question

I am having problem with getting parameter from javascript onClick function

title = "as"
$('<li onClick=pushRight('+hello+') class="item"></li>')

and my console log print this Uncaught SyntaxError: Unexpected token }

Why don't you set-up a jQuery event handler for that element instead? — fbynite
– fbynite, Commented Dec 19, 2013 at 7:33

m59 · Accepted Answer · 2013-12-19 07:42:29Z

3

Please don't use inline js (onlick in your html).

See reasons not to use inline js here: https://www.google.com/search?q=Why+is+inline+js+bad%3F

Here's a proper way with jQuery:

var $myElem = $('<li class="item"></li>');
$myElem.click(function() {
  pushRight('hello');
});

And it's quite easy even without jQuery:

var myElem = document.createElement('li');
myElem.className = 'item';
myElem.addEventListener('click', function() {
  pushRight('hello');
});

Live demo here: http://jsbin.com/uDURojOY/1/edit

edited Dec 19, 2013 at 7:42

answered Dec 19, 2013 at 7:37

m59

43.9k14 gold badges122 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ankit Tyagi · Accepted Answer · 2013-12-19 07:33:37Z

0

Try this way :

hello = 'anything';
$('<li onClick=pushRight("'+hello+'") class="item"></li>')

answered Dec 19, 2013 at 7:33

Ankit Tyagi

2,37511 silver badges20 bronze badges

Comments

Subin Jacob · Accepted Answer · 2013-12-19 09:14:05Z

-1

title = "as"
$('<li onClick="pushRight("'+hello+'")" class="item"></li>')

See the added double quotes. "'+hello+'" Also double quotes over your pushRight function.

Your code won't work because it render an invalid html as shown below.

<li onClick=pushRight(as) class="item"></li>

See, there were no quotes before and after pushRight, also before and after your string "sa". Know the mistake and correct. Using inline js with html is not recommended.You have to bind events in these scenarios.

edited Dec 19, 2013 at 9:14

answered Dec 19, 2013 at 7:34

Subin Jacob

4,92410 gold badges39 silver badges70 bronze badges

Collectives™ on Stack Overflow

passing parameter to javascript onclick function

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related