PHP syntax error “unexpected $end” at last line

Question

I have that code included to the main.php and received syntax error “unexpected $end” at last line of this code even I put the } for the while loop. Please help

<?php
while($row=mysql_fetch_array($rs))
{
    ?>
    <div class="center_title_bar"><?php echo $row['ProName']?></div>
    <div class="prod_box_big">
        <div class="top_prod_box_big"></div>
        <div class="center_prod_box_big">
            <?php
            echo"<div class='product_img_big'>"; 
                echo"<a href='javascript:popImage('".$row['ProPicture']."','".$row['ProName']."') title='".$row['ProName']."'><img src='".$row['ProPicture']."' alt='' border='0' /></a>";
            echo"</div>";
            echo"<div class='details_big_box'>";
                echo"<div class='product_title_big'>'".$row['ProName']."'</div>";

                echo"<div class='specifications'>'".$row['ProInfo']."'<br />"; 
                    echo"Trạng thái: <span class='blue'>";
                    if($row['ProQuantity'])
                    {
                        echo"Còn hàng";
                    }
                    else {
                        echo"Hết hàng";
                    }
                    echo"</span><br />";
                    echo"Bảo hành: <span class='blue'>".$row[ProWarranty]." tháng</span><br />";
                echo"</div>";

                echo"<div class='prod_price_big'><span class='price'>".number_format($row['ProPrice'],0,',','.')." VND</span></div>";
                    echo'<a href="?options=giohang&action=add&item='.$row[ProID].'" class="addtocart">Thêm vào giỏ</a>';
                    ?> 
                    <a href="location:history.back()" class='compare'>Quay lại</a>
                </div>
            </div>
        </div>
        <div class="bottom_prod_box_big"></div>
}

Parse error: syntax error, unexpected $end in

The first error that pops out to me is <?php echo $row['ProName']?>... you're missing a semicolon. There might be more errors; I stopped looking after that one. — Danny Beckett
– Danny Beckett, Commented Dec 14, 2013 at 3:24
But even I tried putting the last } to close the loop, I still have Parse error: syntax error, unexpected $end in — Tuyen Nguyen
– Tuyen Nguyen, Commented Dec 14, 2013 at 3:30
Please open PHP tag before } and close PHP tag after } -- <?php } ?> — Kevin G Flynn
– Kevin G Flynn, Commented Dec 14, 2013 at 4:57

greenish · Accepted Answer · 2013-12-14 03:31:15Z

5

If this is the whole script, you forgot to close the while loop from the begining, at the end of the file.

You need to add:

<?php } ?>

at the end of the file.

edited Dec 14, 2013 at 3:31

answered Dec 14, 2013 at 3:24

greenish

1,0421 gold badge8 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Tuyen Nguyen Over a year ago

Yeah, you're so brilliant.

greenish Over a year ago

Hm.. I can't find any other error in this script.. are you sure the error comes from this script?

Tuyen Nguyen Over a year ago

Mr Greenish, can you help me analyze this code line:

echo"<a href='javascript:popImage('".$row['ProPicture']."','".$row['ProName']."') title='".$row['ProName']."'><img src='".$row['ProPicture']."' alt='' border='0' /></a>";

I just get back <a href='javascript:popImage( in my browser

greenish Over a year ago

The problem is, that you use ' to set href='' and inside href you use the same ' to define popImage('','') parameters. Try using \" instead of ' for html attributes like href.

Bhupendra · Accepted Answer · 2013-12-14 04:53:46Z

this is the script without error

while ($row = mysql_fetch_array($rs)) {
                    ?>
                    <div class="center_title_bar"><?php echo $row['ProName'] ?></div>
                    <div class="prod_box_big">
                        <div class="top_prod_box_big"></div>
                        <div class="center_prod_box_big">
                            <?php
                            echo"<div class='product_img_big'>";
                            echo"<a href='javascript:popImage('" . $row['ProPicture'] . "','" . $row['ProName'] . "') title='" . $row['ProName'] . "'><img src='" . $row['ProPicture'] . "' alt='' border='0' /></a>";
                            echo"</div>";
                            echo"<div class='details_big_box'>";
                            echo"<div class='product_title_big'>'" . $row['ProName'] . "'</div>";

                            echo"<div class='specifications'>'" . $row['ProInfo'] . "'<br />";
                            echo"Trạng thái: <span class='blue'>";
                            if ($row['ProQuantity']) {
                                echo"Còn hàng";
                            } else {
                                echo"Hết hàng";
                            }
                            echo"</span><br />";
                            echo"Bảo hành: <span class='blue'>" . $row[ProWarranty] . " tháng</span><br />";
                            echo"</div>";

                            echo"<div class='prod_price_big'><span class='price'>" . number_format($row['ProPrice'], 0, ',', '.') . " VND</span></div>";
                            echo'<a href="?options=giohang&action=add&item=' . $row[ProID] . '" class="addtocart">Thêm vào giỏ</a>';
                            ?> 
                        <a href="location:history.back()" class='compare'>Quay lại</a>
                    </div>
                </div>
            </div>
            <div class="bottom_prod_box_big"></div>
            <?php
            }

Collectives™ on Stack Overflow

PHP syntax error “unexpected $end” at last line

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related