ASP.NET MVC OutputCacheAttribute: do not cache if a parameter is set?

Question

I have the following action:

public class HomeController : Controller
{
    public ActionResult Index(int? id) { /* ... */ }
}

I'd like to [OutputCache] that action, but I'd like that either:

it doesn't use the cache if id == null; or
it uses the cache if id == null but with a different duration.

I think I can achieve this by:

public class HomeController : Controller
{
    [OutputCache(VaryByParam = "none", Duration = 3600)]
    public ActionResult Index() { /* ... */ }

    [OutputCache(VaryByParam = "id", Duration = 60)]
    public ActionResult Index(int id) { /* ... */ }
}

However this solution implies 2 actions, when the id is actually optional, so this might create some code repetition. Of course I could do something like

public class HomeController : Controller
{
    [OutputCache(VaryByParam = "none", Duration = 3600)]
    public ActionResult Index() { return IndexHelper(null); }

    [OutputCache(VaryByParam = "id", Duration = 60)]
    public ActionResult Index(int id) { return IndexHelper(id); }

    private ActionResult IndexHelper(int? id) { /* ... */ }
}

but this seems ugly.

How would you implement this?

Not sure why this was downvoted, so +1.

Gregory
– Gregory

2010-03-09 07:53:37 +00:00
Commented Mar 9, 2010 at 7:53 — Gregory
– Gregory, Commented Mar 9, 2010 at 7:53

Richard Poole · Accepted Answer · 2010-01-06 12:35:42Z

3

I think what you have is probably the cleanest option.

Another option, which I haven't tested, may be to set the VaryByCustom parameter and override GetVaryByCustomString in Global.asax.

public override string GetVaryByCustomString(HttpContext context, string arg)
{
    if (arg.ToLower() == “id”)
    {
        // Extract and return value of id from query string, if present.
    }

    return base.GetVaryByCustomString(context, arg);
}

See here for more information: http://codebetter.com/blogs/darrell.norton/archive/2004/05/04/12724.aspx

answered Jan 6, 2010 at 12:35

Richard Poole

3,98426 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

ASP.NET MVC OutputCacheAttribute: do not cache if a parameter is set?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related