Changing CSS class in jQuery

Question

I'm trying to change the CSS class of a couple DIVs, Linked below is my jFiddle

The only change is that the -selected class actually has a background image which seems to have the background color of the -non-selected class.

The other problem is after selecting another div, you can't select the first one again. What exactly is jQuery doing with the classes? When I add the -non-selected class to it, it should become select-able again, right?

http://jsfiddle.net/9FZcz/

jQuery

$(".selector-box").click(function () {
    $(".selector-box-selected").removeClass("selector-box-selected").addClass("selector-box");
    $(this).removeClass("selector-box").addClass("selector-box-selected");
});

HTML

<div class="selector-box-selected"></div>
<div class="selector-box"></div>
<div class="selector-box"></div>
<div class="selector-box"></div>

CSS

.selector-box{
    margin-bottom:2px;
    width:328px;
    height:46px;
    background-color:rgba(255,255,255,.25);
}
.selector-box-selected{
    margin-bottom:2px;
    width:351px;
    height:46px;
    background-image:url(../images/layout/SelectedArrow.png);
}

I try your code <div class="selector-box"></div> <div class="selector-box"></div> <div class="selector-box"></div> <div class="selector-box"></div> Like this it's work — Vinh
– Vinh, Commented Nov 8, 2013 at 1:56

Fendy Kusuma · Accepted Answer · 2013-11-08 02:07:31Z

5

You should try another way to adding and removing classes, try this one :

$(".selector-box").click(function () {
    $('.selector-box').removeClass("selected");
    $(this).addClass("selected");
});

Updated JsFiddle

answered Nov 8, 2013 at 2:07

Fendy Kusuma

6727 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

asiviero · Accepted Answer · 2013-11-08 02:01:11Z

0

The problem with not being able to select the first one again is that the click event is not being linked to it, since you only apply it to the <div> elements with the class .selector-box. Apart from that, CSS seems fine, check the fiddle: http://jsfiddle.net/9FZcz/2/

answered Nov 8, 2013 at 2:01

asiviero

1,24510 silver badges16 bronze badges

Comments

Vinh · Accepted Answer · 2013-11-08 02:06:14Z

0

I change your code abit

<div name="ss" class="selector-box-selected"></div>
<div name="ss" class="selector-box"></div>
<div name="ss" class="selector-box"></div>
<div name="ss" class="selector-box"></div>

$("div[name=ss]").click(function () {
    $("div[name=ss]").removeClass("selector-box-selected").addClass("selector-box");
    $(this).removeClass("selector-box").addClass("selector-box-selected");
});

don't mind a name SS, change it to what you want :D

edited Nov 8, 2013 at 2:06

answered Nov 8, 2013 at 2:00

Vinh

736 bronze badges

5 Comments

user2062092 Over a year ago

Thank you Vinh, that answers my first question

Vinh Over a year ago

I base on your code but danzkusuma's answer is better, use his code. I recommend

$(".selector-box").click(function () {     $('.selector-box').removeClass("selected");     $(this).addClass("selected"); });

user2062092 Over a year ago

As for my second question, in my actual code, selector-box has a background color while selector-box-selected is a background image. When I click on a 'selector-box' to change it to 'selector-box-selected' it changes the width & height however does not get rid of the background color it seems. Anyone know why this happens?

user2062092 Over a year ago

Vinh - your solution would work except both divs have an opacity of .25 so you can see the other one underneath

Vinh Over a year ago

In chrome I tested, I use your code and make it's opacity is .25 but it's keep working. div with selector-box-selected change width and height and it doesn't laid on other div at all.

plalx · Accepted Answer · 2013-11-08 02:34:07Z

There are already answers posted that suggests solutions that requires some refactoring, like adding a selected class to selected elements rather than having seperate selector-box-selected and selector-box classes.

While I think you should perform the refactoring since it makes the overall design better and leads to less CSS code duplication, here's a solution without refactoring the code.

I kept track of the last selected element to avoid looping over all of boxes to remove the selected class.

DEMO

var selectedBox = $('.selector-box-selected').get();

$('.selector-box').add(selectedBox).click(function () {

    if (selectedBox === this) return;

    selectedBox = $([this, selectedBox])
        .toggleClass('selector-box-selected')
        .toggleClass('selector-box')
        .get(0);
});

Collectives™ on Stack Overflow

Changing CSS class in jQuery

4 Answers 4

Comments

Comments

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related