0

I am trying to extract one element from an array 'shapes' where that element's id is equal to dragID. I want to know if i'm doing it the right way... lots of problems are arising in this, like, sometimes some elements gets skipped while pushing them back to real array from reserve array. Kindly tell me if there is a better way to do it..

 var reserveShapes = [];
    while(1)
    {
        drag = shapes.pop();
        if(drag.id == dragID)
        {
             break;
        }
        reserveShapes.push(drag);   
    }

    //alert(reserveShapes.length);
    for(var j=0; j<reserveShapes.length; j++)
    {
        ar temp = reserveShapes.pop();
        shapes.push(temp);
    }
Improve this question
1

2 Answers 2

Reset to default
3

Wow. Your idea may work, but there's a much cleaner way:

var drag;
for (int i = 0; i < shapes.length; i++) {
    if (shapes[i].id == dragID) {
         drag = shapes[i];
         break;
    }
}

if (drag) {
    // a matching shape was found
    // ...
}

If you want to remove that element from its position in the array, use splice:

    if (shapes[i].id == dragID) {
        drag = shapes.splice(i, 1);
        break;
    }

You definitely don't have to use push and pop to go through an array.

EDIT References showing you can access an array using []

The reading is kind of dense, but the specification for ECMA-262 (the latest standard to which JavaScript subscribes) is at http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf. On page 67, it says:

Properties are accessed by name, using either the dot notation: 
    MemberExpression . IdentifierName 
    CallExpression . IdentifierName 
or the bracket notation: 
    MemberExpression [ Expression ] 
    CallExpression [ Expression ]

The [] accessor is actually allowed on all objects, and arrays are special objects. Page 122 defines an array:

Array objects give special treatment to a certain class of property names. A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 2^ 32 - 1. A property whose property name is an array index is also called an element. Every Array object has a length property whose value is always a nonnegative integer less than 2^ 32.

What this boils down to is "if you use numbers as indices to the properties of an object, that object is treated as an array."

The spec is fairly dense to read, so here are some easier references to using arrays in JavaScript:

Improve this answer
Sign up to request clarification or add additional context in comments.

4 Comments

I wish it was that easy but it's JavaScript, NOT C++.... you can't access an element like [i] in JavaScript :/
@AbdulJabbar Sure you can. What makes you think you can't??
Damn. Sorry, i'm new to JavaScript.... never really tried accessing an element like that. Had my mind set that its only possible through push and pop. Thanks for enhancing my knowledge. Much appreciated. Your code works fine!
@AbdulJabbar To be fair, I was under the same misconception for a while when I first started. But JavaScript (and ECMAScript) is intended to not be horrible to use, so "normal" array access makes sense.
1

A slightly more modern method from ECMAScript 5:

var drag;
shapes = shapes.filter( function (current) {
    if( current.id === dragID ) {
        drag = current;
        return false;
    }

    return true;
} );

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter

Improve this answer

8 Comments

I was considering this, but the matching value is removed from the array, but is no longer usable by subsequent code.
He didn't say he wanted to keep the cut off element, and if he did, it could still be done with filter. Also, he never said the id is unique.
My bad (Although it was clear from code). I need to store the matching object in the drag object.. and also, id is unique!
Glad to have helped. Please do look at @ScottMermelstein's answer, though, as he clarifies an apparent misunderstanding regarding arrays.
Please refer to the documentation I linked to. In short words, true signals to keep the element, false signals to throw the element away. filter returns the array with all elements where the function returned true.
|

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.