Issue with Implementing callback in node.js code

Question

I have this node.js function process() which is supposed to return a value when called. I am facing issue with creating a callback for my process(). The value should return from process() only after it gets response back from ec2.runInstances(params, function(err, data) call.

------------- Snippet from app.js (express.js)--------------------

var createEngine = require('./ec2_create.js');
app.get('/create', function (req, res) {
    res.render('create', {
        status: createEngine.process()
    });

});

------------------------Code snippet from ec2_create.js -----------------------

function process(callback) {

    var status = null;
    // Create the instance
    ec2.runInstances(params, function (err, data) {
        if (err) {
            //console.log("Could not create instance", err); 
            status = "Could not create instance: " + err;
        } else {
            var instanceId = data.Instances[0].InstanceId;
            //console.log("Created instance", instanceId);
            status = "Created instance: " + instanceId;
        }

    });
    callback(status);
};

module.exports.process = process;

You should avoid using the name 'process' for your function. There is already a global object in Node called 'process' nodejs.org/api/globals.html#globals_process. — Brett
– Brett, Commented Oct 31, 2013 at 7:27

HILARUDEEN S ALLAUDEEN · Accepted Answer · 2013-10-31 07:29:35Z

1

Try as follows

function ec2process(callback){

var status = null;
// Create the instance
ec2.runInstances(params, function(err, data) {
if (err) { 
    //console.log("Could not create instance", err); 
    status = "Could not create instance: " + err;   
    }
else{
    var instanceId = data.Instances[0].InstanceId;
    //console.log("Created instance", instanceId);
    status = "Created instance: " + instanceId; 
  } 
callback(status); // Callback moved

});


};

exports. process = ec2process

answered Oct 31, 2013 at 7:29

HILARUDEEN S ALLAUDEEN

1,7621 gold badge20 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

gherkins · Accepted Answer · 2013-10-31 07:29:51Z

1

since your process method expects a callback function and does not return a value, you could call it rather like this:

app.get('/create', function (req, res) {
    createEngine.process(function(status){
        //you're inside the callback and therefor have the status value
        res.render('create', {
            status: status
        });
    }):  
});

answered Oct 31, 2013 at 7:29

gherkins

15.1k7 gold badges47 silver badges74 bronze badges

Comments

Brett · Accepted Answer · 2013-10-31 07:28:47Z

0

You should move the code which calls the callback into the callback for runInstances:

function process(callback) {

  var status = null;
  // Create the instance
  ec2.runInstances(params, function (err, data) {
    if (err) {
        //console.log("Could not create instance", err); 
        status = "Could not create instance: " + err;
    } else {
        var instanceId = data.Instances[0].InstanceId;
        //console.log("Created instance", instanceId);
        status = "Created instance: " + instanceId;
    }
    callback(status);
  });

};

answered Oct 31, 2013 at 7:28

Brett

3,8853 gold badges26 silver badges28 bronze badges

Collectives™ on Stack Overflow

Issue with Implementing callback in node.js code

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related