change image using javascript based on function result

Question

I've been searching and trying to figure this out for hours but i seem to be missing something. Basically i'm trying to make it so if i click a link/button it executes a script to increase or decrease the number by a specified amount in a function. (in this example its by 1)

The image files that im trying to display are supposed to change depending on the final result. but the image never changes.

any suggestions are greatly appreciated

<script type="text/javascript">

var p1hps = 20;
var p1hpimage

function p1p1Click() {
    p1hps = (p1hps +1);
    function p1health(){
    };
}

function p1health() {
    p1hpimage = "images/p1" + p1hps + ".png";
    document.getElementById('p1hp').src = p1health();
}
</script>




<body>
<a href="#" onclick="p1p1Click()"><img src="images/p1p1.png" width="165" height="87" alt=""></a>
<img src="images/p120.png" id="p1hp" width="324" height="252" alt="">
</body>

You're calling your p1health method incorrectly. Try just p1health(); — jasonscript
– jasonscript, Commented Oct 17, 2013 at 2:27

Arun P Johny · Accepted Answer · 2013-10-17 02:31:58Z

1

You need to invoke the p1health function inside p1p1Click, instead you were declaring another function with the name p1health inside p1p1Click.

Also the images src property, you need to assign the value of the variable p1hpimage instead of recursively calling the p1health method

var p1hps = 20;
function p1p1Click() {
    p1hps++;
    p1health();
}
function p1health() {
    var p1hpimage = "images/p1" + p1hps + ".png";
    document.getElementById('p1hp').src = p1hpimage ;
}

Demo: Fiddle -- _{inspect the source with dev tools to see the src getting updated}

edited Oct 17, 2013 at 2:31

answered Oct 17, 2013 at 2:26

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tilak · Accepted Answer · 2013-10-17 04:31:27Z

0

Try this :

var _myPicArray =new Array("pic1.png","pic2.png","pic3.png");

function p1health(n) {
    document.getElementById('p1hp').src = myPicArray[n] ;
}

answered Oct 17, 2013 at 4:31

tilak

4,7216 gold badges36 silver badges46 bronze badges

Collectives™ on Stack Overflow

change image using javascript based on function result

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related