Can't use parameterized SQL Statements with Node.js and Postgres

Question

I've been banging my head with this since last night. When I add parameters to the sql, it doesn't work.

var findOne = function(username, cb) {
    pg.connect(pgURL, function(err, client, done) {
        var query = client.query('SELECT * FROM users WHERE username = $1', [username]);
        done();

        query.on('row', function(row) {
            cb(err, row);
        });
    });
};

However, if I do an SQL statement without parameterization it works just fine.

var query = client.query("SELECT * FROM users WHERE username = 'foobar'");

Also, doing a console.log(query), right after done(), yields the following:

13:48:00 web.1  | { domain: null,
13:48:00 web.1  |   _events: null,
13:48:00 web.1  |   _maxListeners: 10,
13:48:00 web.1  |   name: undefined,
13:48:00 web.1  |   text: 'SELECT * FROM users WHERE username = $1',
13:48:00 web.1  |   values: [ '{"username":"foobar"}' ],
13:48:00 web.1  |   callback: undefined,
13:48:00 web.1  |   _result: 
13:48:00 web.1  |    { command: null,
13:48:00 web.1  |      rowCount: null,
13:48:00 web.1  |      oid: null,
13:48:00 web.1  |      rows: [],
13:48:00 web.1  |      fields: [],
13:48:00 web.1  |      _parsers: [],
13:48:00 web.1  |      RowCtor: null },
13:48:00 web.1  |   _addedFields: false,
13:48:00 web.1  |   _canceledDueToError: false }

What am I doing wrong here?

Dan Kohn · Accepted Answer · 2013-09-15 21:25:57Z

1

Your username variable appears to be a Javascript object with key username and value foobar. Try username.username to reference just the value.

Alternatively, I highly recommend the ORM Sequelize, which sits on top of pg. Take a look here: http://sequelizejs.com/documentation#usage-raw-queries

answered Sep 15, 2013 at 21:25

Dan Kohn

34.4k9 gold badges91 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ahmed Over a year ago

Great catch. Thanks, that's exactly what the issue was.

Dan Kohn · Accepted Answer · 2013-09-15 19:47:44Z

0

Are you sure username is a string? Try doing username.toString().

answered Sep 15, 2013 at 19:47

Dan Kohn

34.4k9 gold badges91 silver badges100 bronze badges

1 Comment

Ahmed Over a year ago

adding username.toString(), did not change results. I've added the output of console.log(query) (which I added right after done()) to the original post.

Collectives™ on Stack Overflow

Can't use parameterized SQL Statements with Node.js and Postgres

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related