Adding a View inside a ScrollView programmatically

Question

This is the xml code:

<LinearLayout 
    android:id="@+id/mainLayout"
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:paddingBottom="@dimen/activity_vertical_margin"
    android:paddingLeft="@dimen/activity_horizontal_margin"
    android:paddingRight="@dimen/activity_horizontal_margin"
    android:paddingTop="@dimen/activity_vertical_margin"
    tools:context=".MainActivity"
    android:orientation="vertical"
    android:background="@color/black" >

    <ScrollView
        android:id="@+id/mainScrollView"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:background="@color/teal"
        android:layout_weight=".50">

     <LinearLayout
            android:id="@+id/linearLayout1"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:orientation="vertical" >

     </LinearLayout>


    </ScrollView>

    <Button 
         android:id="@+id/addButton"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:text="+"
         android:gravity="center"
         android:layout_weight=".20"
     />

     <TextView
         android:id="@+id/totalHoursLabel"
         android:text="Ore Totali"
         android:background="@color/gray"
         android:textColor="@color/red"
         android:gravity="center"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_weight=".10"
     />

     <TextView
         android:id="@+id/totalHoursView"
         android:text="00:00"
         android:background="@color/white"
         android:textColor="@color/black"
         android:gravity="center"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_weight=".20"
     />

</LinearLayout>

My problem is that when I try to add a view to the ScrollView or his inner LinearLayout my program crashes.

Here is my java code:

super.onCreate(savedInstanceState);

LinearLayout ll = (LinearLayout) findViewById(R.id.linearLayout1);

TextView tv = new TextView(this);
tv.setText("testView");
tv.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT));
ll.addView(tv);

setContentView(R.layout.activity_main);

If I create a new android project this code (with only a relativeLayout and everything else empty in the xml file) works fine.

I think that there is some problem with the findViewById method or my xml file.

Any ideas?

This is my LogCat file:

07-23 15:56:19.119: D/AndroidRuntime(1249): Shutting down VM
07-23 15:56:19.119: W/dalvikvm(1249): threadid=1: thread exiting with uncaught exception (group=0x40a71930)
07-23 15:56:19.159: E/AndroidRuntime(1249): FATAL EXCEPTION: main
07-23 15:56:19.159: E/AndroidRuntime(1249): java.lang.RuntimeException: Unable to start activity ComponentInfo{workTimer.worktimer/workTimer.worktimer.MainActivity}: java.lang.NullPointerException
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2180)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2230)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.ActivityThread.access$600(ActivityThread.java:141)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1234)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.os.Handler.dispatchMessage(Handler.java:99)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.os.Looper.loop(Looper.java:137)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.ActivityThread.main(ActivityThread.java:5041)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at java.lang.reflect.Method.invokeNative(Native Method)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at java.lang.reflect.Method.invoke(Method.java:511)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:793)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:560)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at dalvik.system.NativeStart.main(Native Method)
07-23 15:56:19.159: E/AndroidRuntime(1249): Caused by: java.lang.NullPointerException
07-23 15:56:19.159: E/AndroidRuntime(1249):     at workTimer.worktimer.MainActivity.onCreate(MainActivity.java:32)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.Activity.performCreate(Activity.java:5104)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1080)
07-23 15:56:19.159: E/AndroidRuntime(1249):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2144)
07-23 15:56:19.159: E/AndroidRuntime(1249):     ... 11 more
07-23 15:56:22.649: I/Process(1249): Sending signal. PID: 1249 SIG: 9

Can you post the logcat?

Heinrisch
– Heinrisch

2013-07-23 15:45:32 +00:00
Commented Jul 23, 2013 at 15:45 — Heinrisch
– Heinrisch, Commented Jul 23, 2013 at 15:45
I think I solved your problem, have a look at my answer

SimonDahrs
– SimonDahrs

2013-07-23 16:05:17 +00:00
Commented Jul 23, 2013 at 16:05 — SimonDahrs
– SimonDahrs, Commented Jul 23, 2013 at 16:05

SimonDahrs · Accepted Answer · 2013-07-23 15:58:18Z

10

You have to call setContentView before you can call findViewById, so your code will be:

super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);

LinearLayout ll = (LinearLayout) findViewById(R.id.linearLayout1);

TextView tv = new TextView(this);
tv.setText("testView");
tv.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT));
ll.addView(tv);

answered Jul 23, 2013 at 15:58

SimonDahrs

2,4096 gold badges27 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kami Over a year ago

Thanks, but it did not work. Actually I had already tried to change that line.

SimonDahrs Over a year ago

Then you should check your id's and stuff again because the code is right this way (findviewbyid after setcontentview!)

Lisa Wray · Accepted Answer · 2013-07-23 15:49:19Z

0

My guess is that you're using the wrong LayoutParams. The LayoutParams of a view should have the type of its parent. In your case:

tv.setLayoutParams(new LinearLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT));

Also, you are adding the TextView twice to your LinearLayout.

ll.addView(tv);

ll.addView(tv);

Don't do this. Create a second TextView and add that if you need two TextViews in there.

If these don't help, post your crash log from LogCat and I can help you from there.

answered Jul 23, 2013 at 15:49

Lisa Wray

2,27218 silver badges23 bronze badges

2 Comments

Lisa Wray Over a year ago

Did you try changing the type of the LayoutParams? And please post your logcat.

Kami Over a year ago

I tried to change the parameters, but it did not work. I added my logcat. Thanks.

Collectives™ on Stack Overflow

Adding a View inside a ScrollView programmatically

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related