php when to use array as a parameter/property

Question

For the following two classes:

should I use array as a parameter or one by one?

class image {

    public function __construct(array $color, array $padding) {
        ...
    }
}

class image {

    public function __construct($red, $green, $blue, $paddingtop, $paddingright, $paddingbottom, $paddingleft) {
        ...
    }
}

Also for class properties:

class image {
    protected $paddingtop;

    protected $paddingright;

    protected $paddingbottom;

    protected $paddingleft;

    protected $colorred;

    protected $colorgreen;

    protected $colorblue;
}

class image {

    protected $padding = array('top' => ..., 'right' => ..., 'bottom' => ..., 'left' => ...);

    protected $color = array('red' => ..., 'green' => ..., 'blue' => ...);

}

Is it better to treat them as an array or a single variable?

Maybe this question don't have a fixed answer, but I'm just a php beginner and don't have any work experience, I wanna hear your suggestion which way is the most common use or easy for other coders to read.

Thanks!

prodigitalson · Accepted Answer · 2013-07-03 02:56:02Z

2

You don't ever want that many arguments to a function... You could use an options array(s) or you could just use setter methods to set the properties. I have a hard time believing all of those would be required to create an object instance.

As far as class properties that depends on the nature of their use. Generally speaking seperate properties are better because it makes for an easier to read interface and helps with IDE code hinting. But in this case, especially the padding, i think it would make more sense to use the array like you have in your second example.

answered Jul 3, 2013 at 2:56

prodigitalson

60.6k10 gold badges106 silver badges118 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Eathen Nutt Over a year ago

I'm making a image edit tool, the class has so many properties such as color, padding, border, resource..so I'm wondering what is the code style that people most use, array or single one

prodigitalson Over a year ago

@user1970939: Yeah i would definitely use setters/getters for that then. The only thing i would probably have in the consturctor would be for canvas size, color model, and possibly a file location or something. all the other stuff i would use like $image->setPadding($arrayOfValues); or $image->setPadding('top', $value); You might want to take a look at the IMagick api for some inspiration...

SergeantHacker · Accepted Answer · 2013-07-03 02:55:21Z

1

This would be completely subjective; however, I will throw my two cents in to the conversation. My rule of thumb is if there are more than 4 parameters than try to bundle them arrays if they make sense together. So, the example's padding and colors go together well as arrays.

Also, try to make the arrays in a fashion that the user does not have to worry about which index each element is in, such as using an associative array.

answered Jul 3, 2013 at 2:55

SergeantHacker

15713 bronze badges

1 Comment

Eathen Nutt Over a year ago

I have an idea, for example, if the properties have the same 'meaning' or 'unit', I will bundle them as an array, such as different padding or rgb for one color, but for fontsize, fontcolor, I will separate them

Collectives™ on Stack Overflow

php when to use array as a parameter/property

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related