Encode HTML for JSON string

Question

I am storing html in a mysql database as raw html. I am pulling the contents and placing it into an array as follows. The array is the json_encoded, but if there is any double quotes or urls then the javascript displaying the JSON string breaks.

Is it possible to encode html to work through JSON?

Here is an extract of what I am using

    <?php
    $rows = array();
    $sql ="SELECT html FROM table";

    try {  
        $sth = $dbh->query($sql); 
        while($r = $sth->fetch(PDO::FETCH_OBJ)) {
            $rows[] = $r;
        }
    }
    catch(PDOException $e) {  
        echo "I'm sorry, Dave. I'm afraid I can't do that. $e";  
    } 
    ?>

var json = JSON.parse('<?php print json_encode(json_encode($rows)); ?>');

The json string currently outputting throws a javascript error saying unexpected <

[{"html":"<a href="http:\/\/www.url.com">\n<img src="http:\/\/www.url.com\/img\/logo.png">\n<\/a>"}]

Please no lectures on why this may be a bad thing. This is what my client has requested specifically and I just need to know if it is possible.

idk if is a typo or actual issue but, you select column hmtl, isn't it html? — Frederik.L
– Frederik.L, Commented Jun 11, 2013 at 21:59

Robert · Accepted Answer · 2013-06-11 21:55:54Z

3

I agree with Mark B's answer but you could use fetchAll() and json_encode() the result of this function. Why do you use PDO Object fetching instead of array fetching?

<?php
$rows = array();
$sql ="SELECT hmtl FROM table";

try {  
    $sth = $dbh->query($sql); 
    $rows = $sth->fetchAll(PDO::FETCH_ASSOC);
}
catch(PDOException $e) {  
    echo "I'm sorry, Dave. I'm afraid I can't do that. $e";  
} 
?>

var json = <?= json_encode($rows); ?>;

Moreover consider getting it via AJAX.

answered Jun 11, 2013 at 21:55

Robert

20.3k6 gold badges58 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

hammus Over a year ago

2001 reference gets a +1 every time.

Marc B · Accepted Answer · 2013-06-11 21:54:37Z

2

There's no need for the json.parse business. JSON IS valid javascript after all, so a simple

var json = <?php echo json_encode($rows); ?>;

is all you need.

answered Jun 11, 2013 at 21:54

Marc B

362k44 gold badges433 silver badges508 bronze badges

1 Comment

Somk Over a year ago

I have changed it to this as you said and updated my question

T.J. Crowder · Accepted Answer · 2013-06-11 21:49:42Z

2

The line

var json = JSON.parse('<?php print json_encode(json_encode($rows)); ?>');

...is susceptible to single quotes in the resulting JSON (and other things; you'd have to double-escape lots of stuff). But you don't need or want to do that. Do this:

var json = <?php print json_encode(json_encode($rows)); ?>;

json_encode returns valid JSON, and JSON is a subset of JavaScript object initializer syntax, and so the above will result in valid JavaScript code describing the object. If you're outputting JavaScript code, as you appear to be from that line, there's no reason to go indirectly through a string. And as you've found, there's a reason not to.

answered Jun 11, 2013 at 21:49

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Comments

Kreshnik Hasanaj · Accepted Answer · 2013-06-11 21:52:07Z

-1

Before filling the JSON object, you could use htmlentities() to convert all applicable characters to HTML entities, and then when printing them out just use html_entity_decode() if you use an ISO standard as character set. Sorry if I might have misunderstood the question.

answered Jun 11, 2013 at 21:52

Kreshnik Hasanaj

5,0151 gold badge18 silver badges18 bronze badges

1 Comment

T.J. Crowder Over a year ago

HTML entities are irrelevant to JavaScript code unless it's in an HTML attribute value, which we have no reason to suspect the OP's var json = ... line is (and several reasons to suspect it isn't).

Collectives™ on Stack Overflow

Encode HTML for JSON string

4 Answers 4

1 Comment

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related