Error Calling powershell script from batch file in separate directory

Question

I have the following .ps1 for unzipping a zip file...

param([string]$path)
$shell=new-object -com shell.application
$Location=$shell.namespace($path)
$ZipFiles = get-childitem *.zip

get-childitem $path -include *.xml -recurse | foreach ($_) {remove-item $_.fullname}

foreach ($ZipFile in $ZipFiles)
{
    $ZipFile.fullname | out-default
    $ZipFolder = $shell.namespace($ZipFile.fullname)
    $Location.Copyhere($ZipFolder.items())
}

and the following run.bat file for setting the parameter and calling the .ps1

 powershell -command "C:\Users\eric\unzipFile\unzip3.ps1 -path \"C:\Users\eric\unzipFile\""

If both are in the same directory, no error, however if I move the run.bat to another directory I get the following...

You cannot call a method on a null-valued expression.
At C:\Users\eric\unzipFile\unzip3.ps1:12 char:38
+ $Location.Copyhere($ZipFolder.items <<<< ())
+ CategoryInfo: InvalidOperation: (items:String) [], RuntimeException
+ FullyQualifiedErrorId : InvokeMethodOnNull

It's probably this $ZipFiles = get-childitem *.zip. Add Write-Host $pwd before that to see where it's looking for *.zip. — Andy Arismendi
– Andy Arismendi, Commented May 21, 2013 at 20:34
Thank you, was looking in the current directory instead of the path handed to it — eric MC
– eric MC, Commented May 21, 2013 at 20:42

Lars Truijens · Accepted Answer · 2013-05-21 20:49:22Z

2

You didn't specify in which path to look for zip files, so it looks in the current folder. Change it as follow:

$ZipFiles = get-childitem -Path $path -Filter *.zip

Other tip: Use the -File parameter from powershell and add other parameters to make it easier to call

powershell -file "C:\Users\eric\unzipFile\unzip3.ps1" -path "C:\Users\eric\unzipFile\"

answered May 21, 2013 at 20:49

Lars Truijens

43.9k6 gold badges134 silver badges146 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Error Calling powershell script from batch file in separate directory

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related