Changing a an image src file using javascript wont change picture displayed

Question

essentially i have this div

<div id="trafficcam" style="text-align:center;display:none;">
<img id="image" src="http://131940.qld.gov.au/DMR.Controls/WebCams/DisplayImage.ashx?FilePath=Gold_Coast/GrandisSth.jpg" alt="Sorry, no traffic cam is available">

and I'd like to change the src of the file so that when a button is pressed the image changes. I can't really hide it and have it show a different one because this div is for the traffic cams, and i'd rather have it a bit more compact.

the button to execute it is

<input type=button  value="cam" onclick="selectCam()">

which i have tested and it works

the function it calls is:

      function selectCam()
{
alert(document.getElementById("image"))
             document.getElementbyId("image").src="http://i.imgur.com/zP9kTfe.jpg";

         }

which seems to not change anything on the page when the button is pressed

You forgot a semi colon after the alert. This will stop the js from running — tymeJV
– tymeJV, Commented May 18, 2013 at 16:09
@tymeJV No it wouldn't. Why would the semicolon there change anything? — Ian
– Ian, Commented May 18, 2013 at 16:11
the issue happens with or without the alert, and there is no error. The image just doesn't just change. — Ricky Charles
– Ricky Charles, Commented May 18, 2013 at 16:11

Artem Sobolev · Accepted Answer · 2013-05-18 16:09:45Z

2

There is no method getElementbyId, it's called getElementById. Check out the error console, there should be something like

Unhandled Error: 'document.getElementbyId' is not a function

answered May 18, 2013 at 16:09

Artem Sobolev

6,1191 gold badge25 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Niet the Dark Absol Over a year ago

More generally, JavaScript is case-sensetive.

Ricky Charles Over a year ago

jfc that was all it was. Thank you. Been working on this for two days ;_;

Ricky Charles Over a year ago

hey, i've applied your change and it worked in the button, but now it wont work in a drop down menu, any ideas?

Ricky Charles Over a year ago

pastebin.com/4CGLPgpf this is the full code, I wasn't getting any run time errors. No files are local, just running it in coda.

Artem Sobolev Over a year ago

Had it worked before? I think it's better to use a select's onchange event rather than option's onclick.

|

Alastair Irvine · Accepted Answer · 2013-12-11 13:32:19Z

0

Also watch out for the insidious getElementByID (the "D" shouldn't be capitalised).

answered Dec 11, 2013 at 13:32

Alastair Irvine

1,17812 silver badges16 bronze badges

Collectives™ on Stack Overflow

Changing a an image src file using javascript wont change picture displayed

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related