Find biggest and smallest array Javascript

Question

I am trying to figure out the best way to compare two arrays.

Essentially I want to know the biggest and smallest array for further processing. Here is my code for doing so thus far:

merge: function(arrOne, arrTwo) {

   if(arrOne == null || arrTwo == null) throw new Error();

    var bigArr = arrOne.length > arrTwo.length ? arrOne : arrTwo,
        smallArr = bigArr.length == arrOne.length ? arrTwo : arrOne;

    console.log(bigArr);
    console.log(smallArr);

}

While this works, I am guessing there has to be an easier and more efficient way of doing this. Any thoughts?

I would change your =='s to ==='s impressivewebs.com/why-use-triple-equals-javascipt — Jazzepi
– Jazzepi, Commented Mar 29, 2013 at 18:40
@SethenMaleno as I said, it's a mess. If someoneone used it in our codebase where if could have been used, I would get a huge ? and bludgeon that guy. — John Dvorak
– John Dvorak, Commented Mar 29, 2013 at 18:44
@Jazzepi note that referencing a non-existent property is not an error. console.log(window.foo) — John Dvorak
– John Dvorak, Commented Mar 29, 2013 at 18:50

John Dvorak · Accepted Answer · 2013-03-29 19:03:05Z

The best way would be to not use a ternary, and write a normal condition.

var bigArr, smallArr;
if(arrOne.length > arrTwo.length){
    bigArr = arrOne;
    smallArr = arrTwo;
}else{
    smallArr = arrOne;
    bigArr = arrTwo;
}

Readable, fast, it's obviously bug-free.

If you really want to use a ternary operator (for example to avoid duplicate declaration and assignment after declaration), perhaps the correct solution would be to repeat (or cache) the condition:

var   bigArr = arrOne.length > arrTwo.length ? arrOne.length : arrTwo.length,
    smallArr = arrOne.length > arrTwo.length ? arrTwo.length : arrOne.length;

Somewhat readable, obviously bug free, assigns at declaration.

If you want to avoid if and condition duplication, it's still possible. However, the code is unreadable (mainly because the comma operator is used) and shouldn't be used in production code. It might still be useful for code golf, though, and I'll name the variables appropriately. Handle with care:

l=(a.length>b.length)?(s=b,a):(s=a,b)

Parthik Gosar · Accepted Answer · 2013-03-29 18:49:27Z

0

Your code will fail in cases where are there undefined values inbetween the array. If you need to handle such a condition, you might want to try a totally different approach.

var myArray = new Array();
myArray[100] = true;
console.log(myArray.length); // returns 101

answered Mar 29, 2013 at 18:49

Parthik Gosar

11.7k3 gold badges27 silver badges16 bronze badges

Collectives™ on Stack Overflow

Find biggest and smallest array Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related