Javascript key value array storing

Question

I am here today with a question to do with key value pair arrays.

my html is as follows

<input type="checkbox" class="data" id="task_checked" value="1" email="[email protected]">
<input type="checkbox" class="data" id="task_checked" value="2" email="[email protected]">

I would like to store the following data as an array like below:

"1" => "[email protected]"
"2" => "[email protected]"

My Javascript currently is as follows:

var newTasksArr = new Array();

$("#task_checked:checked").each(function() {
    var email = $(this).attr("email");
    var id = $(this).val();
    newTasksArr['id'] = email;

});

Perhaps I am using the Jquery .each() wrong, could someone shed some light in to my question please?

Thank you for you reading. Regards.

Frances McMullin · Accepted Answer · 2013-02-20 16:48:06Z

3

Two issues :

In Javascript, an Array may only have sequential, numeric keys. If you want to use strings as keys, you want an Object.

If you want to insert an element with a key equal to the value of id, then you want newTasksArr[id] = email; without the quotes.

answered Feb 20, 2013 at 16:48

Frances McMullin

5,7162 gold badges20 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Peter Olson · Accepted Answer · 2013-02-20 16:48:32Z

1

You're almost right, you just need to remove the quotes around 'id' so that it uses the value the id variable contains, instead of the literal string 'id'.

You should also use an object ({}) instead of an array ([]).

var newTasks = {};
$("#task_checked:checked").each(function() {
    var email = $(this).attr("email");
    var id = $(this).val();
    newTasks[id] = email;
});

answered Feb 20, 2013 at 16:48

Peter Olson

144k49 gold badges209 silver badges249 bronze badges

2 Comments

David Hedlund Over a year ago

@PeterOlson: note that the values of "id" will be sequential integers, though. Your suggested change to an object may have consequences that are unexpected to BaconJuice. Compare: var a=[],b={}; a['0'] = 'x'; a['1'] = 'x'; b['0'] = 'x'; b['1'] = 'x'; alert(a.length); alert(b.length);

Peter Olson Over a year ago

@DavidHedlund He seemed to be fairly specifically asking for key-value storage, but it looks like he might be coming from PHP, which conflates arrays and key-value dictionaries even more than JavaScript does.

Mark Graham · Accepted Answer · 2013-02-20 17:07:40Z

0

Avoid duplicating Ids in your markup. The following should help, however you might want to tweek the jquery selector to include a context.

var arr = {};

$('input:checked').each(function() {
    var $t = $(this);

    var email = $t.attr("email");
    if (!email) {
        // you may wish to do something if email is missing
    }

    var id = $t.val();
    if (!id) {
        // deal with the error
    }

    arr[id] = email;
});

edited Feb 20, 2013 at 17:07

answered Feb 20, 2013 at 16:53

Mark Graham

1716 bronze badges

Collectives™ on Stack Overflow

Javascript key value array storing

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related