Iframe src change with Javascript not working

Question

I currently have some Javascript that looks a bit like this:

<script src="//ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
<script>
$(document).ready(function(){
function changeSource(newSource) {
  document.getElementById('preview').src = newSource;
}
});
</script>

Then I have some HTML that looks like this:

<table border=0 class="colors">
  <tbody>
    <tr>
      <td><a onclick="changeSource('http://www.test.com')"><img width="40" src="test.png"/></a></td>
    </tr>
  </tbody>
</table>

Then the Iframe section:

<table border=0>
  <tbody>
    <tr>
      <td><iframe id="preview" width="125" height="303" src="test.php" scrolling="no" frameborder="0" marginwidth="0" marginheight="0" hspace="0" vspace="0"></iframe></td>
    </tr>
  </tbody>
</table>

However click on the image in the tags the Iframe's source won't change. Why is it like this?

epascarello · Accepted Answer · 2013-01-15 21:43:33Z

2

You are getting an error because the function is a local method since you hid it in the onready function. There is no need for the onready call with that example.

<script>
$(document).ready(function(){
function changeSource(newSource) {
  document.getElementById('preview').src = newSource;
}
});
</script>

needs to be

<script>
  function changeSource(newSource) {
      document.getElementById('preview').src = newSource;
  }
</script>

Better yet, no JavaScript is needed! Use HTML like it is supposed to be used. Use the target attribute.

<td><a href="http://www.example.com" target="preview"><img width="40" src="test.png"/></a></td>

answered Jan 15, 2013 at 21:43

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1981730 Over a year ago

Worked perfectly, thank you so much. I will accept your answer once the time runs out.

Priya · Accepted Answer · 2013-10-22 04:51:11Z

0

You are using jquery. Better make a perfect use.

$(document).ready(function(){
    // selecting anchor tag for table with class colors
    $("table.colors a").click(function(e){
        e.preventDefault();
        var newSource = $(this).attr("href");
        $("#preview").attr({"src" : newSource});
    });
});

No need of messing with html by adding onclick attribute or target attribute. But html's target attribute is most preferable.

<table border=0 class="colors">
  <tbody>
    <tr>
      <td><a href="http://www.test.com"><img width="40" src="test.png"/></a></td>
    </tr>
  </tbody>
</table>

answered Oct 22, 2013 at 4:51

Priya

1,5541 gold badge14 silver badges33 bronze badges

Collectives™ on Stack Overflow

Iframe src change with Javascript not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related