Getting an Error Trying to Create an Object in Python

Question

I am trying to create an object from a class in python but I am getting an Error, "e_tank = EnemyTank() TypeError: 'Group' object is not callable"

I am not sure what this means, I have tried Google but I couldn't get a clear answer on what is causing this error. Does anyone understand why I am unable to create an object from my EnemyTank Class?

Here is my code:

#Image Variables
bg = 'bg.jpg'
bunk = 'bunker.png'
enemytank = 'enemy-tank.png'

#Import Pygame Modules
import pygame, sys
from pygame.locals import *

#Initializing the Screen
pygame.init()
screen = pygame.display.set_mode((640,360), 0, 32)

background = pygame.image.load(bg).convert()



bunker_x, bunker_y = (160,0)



class EnemyTank(pygame.sprite.Sprite):
    e_tank = pygame.image.load(enemytank).convert_alpha()
    def __init__(self, startpos):
        pygame.sprite.Sprite.__init__(self, self.groups)
        self.pos = startpos
        self.image = EnemyTank.image
        self.rect = self.image.get_rect()
    def update(self):
        self.rect.center = self.pos

class Bunker(pygame.sprite.Sprite):
    bunker = pygame.image.load(bunk).convert_alpha()
    def __init__(self, startpos):
        pygame.spriter.Sprite.__init__(self, self.groups)
        self.pos = startpos
        self.image = Bunker.image
        self.rect = self.image.get_rect()
    def getCollisionObjects(self, EnemyTank):
        if (EnemyTank not in self._allgroup, False):
            return False
        self._allgroup.remove(EnemyTank)
        result = pygame.sprite.spritecollide(EnemyTank, self._allgroup, False)
        self._allgroup.add(EnemyTank)
    def update(self):
        self.rect.center = self.pos


#Setting Up The Animation
x = 0
clock = pygame.time.Clock()
speed = 250

allgroup = pygame.sprite.Group()
EnemyTank = allgroup
Bunker = allgroup

e_tank = EnemyTank()
bunker = Bunker()5

#Main Loop
while True:
    for event in pygame.event.get():
        if event.type == QUIT:
            pygame.quit()
            sys.exit()

    screen.blit(background, (0,0))
    screen.blit(bunker, (bunker_x, bunker_y))
    screen.blit(e_tank, (x, 0))
    pygame.display.flip()

    #Animation
    milli = clock.tick()
    seconds = milli/1000.
    dm = seconds*speed
    x += dm

    if x>640:
        x=0


    #Update the Screen
    pygame.display.update()

Rather than asking readers to read through all your code, can you cut out the bits that aren't necessary, and try to create a minimal example of your problem? You may well manage to get closer to an answer yourself that way, too! — me_and
– me_and, Commented Nov 15, 2012 at 23:11
Next time, it would be helpful if you gave the line the error occurred on. — ThisIsAQuestion
– ThisIsAQuestion, Commented Nov 16, 2012 at 0:43

Aesthete · Accepted Answer · 2012-11-15 23:02:22Z

4

You've declared a class called EnemyTank and then you've overwritten it with this line:

EnemyTank = allgroup

EnemyTank after this point is not a class, but a group, and no longer callable. What you want to do is:

allgroup pygame.sprite.Group()
e_tank = EnemyTank()
allgroup.add(e_tank)
# Or..
e_tank.add(allgroup)

edited Nov 15, 2012 at 23:02

answered Nov 15, 2012 at 22:55

Aesthete

18.9k6 gold badges38 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nezo · Accepted Answer · 2012-11-15 22:56:47Z

1

Here is your problem :

You instantiate the Group class :

allgroup = pygame.sprite.Group() :

Then you put the object in a EnemyTank variable

EnemyTank = allgroup

Then you try to call the EnemyTank object :

e_tank = EnemyTank()

answered Nov 15, 2012 at 22:56

Nezo

3123 silver badges14 bronze badges

Comments

user1806568 · Accepted Answer · 2012-11-15 22:57:11Z

1

Looks like you've instantiated a Group class:

allgroup = pygame.sprite.Group()

And then you try to call the object:

EnemyTank = allgroup
e_tank = EnemyTank()

I guess pygame.sprite.Group class does not define a __call__() method so it cannot be called

answered Nov 15, 2012 at 22:57

user1806568

Comments

PearsonArtPhoto · Accepted Answer · 2012-11-15 23:13:29Z

0

In addition to the already mentioned, I should also add that you are very close in another instance to repeating variable names, and you should really not do that. Here's every instance of something like EnemyTank I can see.

enemytank = 'enemy-tank.png'
class EnemyTank(pygame.sprite.Sprite):
EnemyTank = allgroup

answered Nov 15, 2012 at 23:13

PearsonArtPhoto

39.9k17 gold badges116 silver badges147 bronze badges

Comments

ninMonkey · Accepted Answer · 2012-11-16 01:47:47Z

0

You define a class EnemyTank but then create a new variable with the same name. EnemyTank

bunker = Bunker()5 # this is also invalid

To use the spritegroups, you do something like

player = PlayerTank()
tanks = [ Tank() for x in range(5) ]
tanks.append( player )

then: drawing

tank.draw(screen)

collision: spritecollide or any of the other collision functions in : http://www.pygame.org/docs/ref/sprite.html

see also: http://www.pygame.org/docs/ref/sprite.html#pygame.sprite.Group

answered Nov 16, 2012 at 1:47

ninMonkey

7,5418 gold badges41 silver badges72 bronze badges

Collectives™ on Stack Overflow

Getting an Error Trying to Create an Object in Python

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related