Java, regular expression catching multiple occurances of pattern

Question

This is my original String:

String response = "attributes[{"id":50,"name":super},{"id":55,"name":hello}]";

I'm trying to parse the String and extract all the id values e.g
50
55

Pattern idPattern = Pattern.compile("{\"id\":(.*),");
Matcher matcher = idPattern.matcher(response);

while(matcher.find()){
    System.out.println(matcher.group(1));
}

When i try to print the value i get an exception: java.util.regex.PatternSyntaxException: Illegal repetition
Not had much experience with regular expressions in the past but cannot find a simple solution to this online.
Appreciate any help!

Madbreaks · Accepted Answer · 2012-11-08 16:38:37Z

3

Pattern.compile("\"id\":(\\d+)");

answered Nov 8, 2012 at 16:38

Madbreaks

19.6k7 gold badges62 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Anirudh Ramanathan · Accepted Answer · 2012-11-08 16:39:39Z

2

Don't use a greedy match operator like * with a . which matches any character. unnecessarily. If you want the digits extracted, you can use \d.

"id":(\d+)

Within a Java String,

Pattern.compile("\"id\":(\\d+)");

answered Nov 8, 2012 at 16:39

Anirudh Ramanathan

46.8k24 gold badges137 silver badges195 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 10:24:41Z

2

{ is a reserved character in regular expressions and should be escaped.

\{\"id\":(.*?),

Edit : If you're going to be working with JSON, you should consider using a dedicated JSON parser. It will make your life much easier. See Parsing JSON Object in Java

edited May 23, 2017 at 10:24

CommunityBot

11 silver badge

answered Nov 8, 2012 at 16:38

Mike Park

11k3 gold badges38 silver badges50 bronze badges

3 Comments

Madbreaks Over a year ago

That .* is going to greedy match, is it not?

Mike Park Over a year ago

@Madbreaks Yep you're right - I glossed over that part and just thought he wanted to know why it was failing to compile

Madbreaks Over a year ago

Is see you fixed it, removed my -1. :) Oops, it won't let me until you edit your answer, maybe put a note in it that you fixed it.

Collectives™ on Stack Overflow

Java, regular expression catching multiple occurances of pattern

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related