Push user input to array

Question

Hi so yes this is a previous issue i have had, i have hit the books and whent back to basics adjusted a few things but im still having trouble getting the input value to push to the array can some one please help me get my head around this thanks

<!DOCTYPE html>
<html>

 <body>
  <script type="text/javascript">
   var number=["1"]
   function myFunction()
   {
    var x=document.getElementById("box");
     number.push=document.getElementById("input").value;
    x.innerHTML=number.join('<br/>'); 
   }
  </script>
 <form>
  <input id="input" type=text>
   <input type=button onclick="myFunction()" value="Add Number"/>
  </form>

 <div id="box"; style="border:1px solid black;width:150px;height:150px;overflow:auto"> 
  </div>
</body>
</html>

Try number.push (document.getElementById("input").value) instead of number.push=document.getElementById("input").value; — sdkljhdf hda
– sdkljhdf hda, Commented Sep 26, 2012 at 6:37

mbinette · Accepted Answer · 2012-09-26 06:34:54Z

4

Here is the mistake:

number.push(document.getElementById("input").value);

push is a method, not an attribute ;-)

JSFiddle

PS: Why the ; after id="box"; ? You should fix that too..! ;-)

answered Sep 26, 2012 at 6:34

mbinette

5,0923 gold badges27 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

11684 Over a year ago

Does that semicolon actually matter with modern, markup-correcting browsers?

mbinette Over a year ago

It's probably not an issue with most browsers (maybe even all!) but it's still not valid code. ;-)

11684 Over a year ago

Going to try with my ancient Safari.

mbinette Over a year ago

Never said it wouldn't ;-) Lot's of things work but aren't good code! That semicolon doesn't belong there! Thanks for testing tho! Which version?

11684 Over a year ago

Version 4.1.3 (4533.19.4). Yes I know, but I was just curious if such a little semicolon matters (in HTML, in JS or most programming languages I know it does).

|

Bill · Accepted Answer · 2012-09-26 06:38:44Z

1

You were close, here's the working code:

<!DOCTYPE html>
<html>

 <body>
  <script type="text/javascript">
   var number = [];

   function myFunction()
   {
     var x = document.getElementById("box");
     number.push(document.getElementById("input").value);
     x.innerHTML = number.join('<br/>'); 
   }
  </script>
 <form>
  <input id="input" type=text>
   <input type=button onclick="myFunction()" value="Add Number"/>
  </form>

 <div id="box" style="border:1px solid black;width:150px;height:150px;overflow:auto"> 
  </div>
</body>
</html>

answered Sep 26, 2012 at 6:38

Bill

25.6k8 gold badges100 silver badges129 bronze badges

Collectives™ on Stack Overflow

Push user input to array

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related