Javascript open window with php variables in link?

Question

what I need to do is open a new window to a link that has php variables in it. As far as I know, I cannot use php variables in javascript functions, so I tried this which does not seem to be working

$link="<script type='text/javascript'>window.open('http://www.fonefinder.net/findome.php?npa=$num1&nxx=$num2&thoublock=$num3&usaquerytype=Search+by+Number&cityname=
')</script>";
echo $link;

$num1, $num2, and $num3 are all php variables. Is there a better way to do this? Thanks.

What is the generated HTML/JavaScript (output) of your PHP script for this small piece of code? It is always important to provide this since there is a difference between what you "see" at the server side (the script) and what you have on the client side (the generated output). — Styxxy
– Styxxy, Commented Sep 1, 2012 at 19:56

Austin Greco · Accepted Answer · 2012-09-01 19:55:22Z

2

Remove linebreak:

$link="<script type='text/javascript'>window.open('http://www.fonefinder.net/findome.php?npa=$num1&nxx=$num2&thoublock=$num3&usaquerytype=Search+by+Number&cityname=')</script>";
echo $link;

Also, you should wrap the variables in braces: ${num1}, otherwise they may be interpolated incorrectly.

answered Sep 1, 2012 at 19:55

Austin Greco

33.6k6 gold badges60 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

CJ Sculti Over a year ago

No, it just does absolutley nothing, as it does not redirect, the way I have it now, with it echoing the script.

Basic Over a year ago

I'd also point out that this will break if the PHP variables include apostrophes or any of a number of other things - You need to first URL encode the parameters urlencode() and then escape them to be used inside a JS String (replace ' and `\` and probably some more). Of course, if you can guarantee it will only ever be a number, this shouldn't be required

su- · Accepted Answer · 2012-09-01 19:59:32Z

1

$link="<script type='text/javascript'>window.open('http://www.fonefinder.net/findome.php?npa=".$num1."&nxx=".$num2."&thoublock=".$num3."&usaquerytype=Search+by+Number&cityname=')</script>";
echo $link;

answered Sep 1, 2012 at 19:59

su-

3,1763 gold badges34 silver badges44 bronze badges

Collectives™ on Stack Overflow

Javascript open window with php variables in link?

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related