Checking value in textbox against an array script not working

Question

I have a script that I am checking values from textbox against an array, the array are all values from a drop down list. Cant seem to get it to work. Thanks.

<script type = "text/javascript">

    function chkName() {

        var ddlArray = new Array();
        var ddl = document.getElementById('DropDownList1');
        for (i = 0; i < ddl.options.length; i++) {
            ddlArray[i] = ddl.options[i].value;
        }



        var str = document.getElementById("TextBox1").value;
        str = str.replace(/^\s+|\s+$/g, ""); // strip leading and trailing spaces
        str = str.toLowerCase().replace(/\b[a-z]/g, function (w) {
            return w.toUpperCase()
        }); // reformat to lower-case with initial capital

        var match = false;
        for (var i = 0; i < ddlArray.length; i++) {
            if (str == ddlArray[i]) {
                match = true;
            }
        }

        if (match) {
            alert("The name " + str + " does  match our list!");
            document.getElementById("TextBox1").value = "";
            return false;
        } else {

            return true;

        }

    }
</script>

Nitpick Doing document.getElementById("TextBox1") over and over again in the same function is bad. Store it in a variable and reference it. Also most modern day browsers support indexOf on arrays. — epascarello
– epascarello, Commented Aug 23, 2012 at 17:02
try to debug your code by yourself. console.log([str, ddlArray[i]]); — Peter
– Peter, Commented Aug 23, 2012 at 17:04
Instead of "new Array()", use "[ ]". And inside of your if statement to check for a match, you can use "break;" after the "match = true;" line. (these won't fix anything, just improve whatever) — Ian
– Ian, Commented Aug 23, 2012 at 17:08

sQVe · Accepted Answer · 2012-08-23 17:05:44Z

2

Try this:

function chkName() {
    "use strict";
    var ddlArray = [],
        ddl = document.getElementById('DropDownList1'),
        str = document.getElementById("TextBox1").value,
        match = false;

    for (var i = 0; i < ddl.options.length; i++) {
        ddlArray[i] = ddl.options[i].value;
    }

    str = str.replace(/^\s+|\s+$/g, "");
    str = str.toLowerCase().replace(/\b[a-z]/g, function( w ) {
        return w.toUpperCase();
    });

    for (i = 0; i < ddlArray.length; i++) {
        if ( str === ddlArray[i] ) {
            alert("The name " + str + " does  match our list!");
            document.getElementById("TextBox1").value = "";
            return false;
        }
    }
    return true;
}

answered Aug 23, 2012 at 17:05

sQVe

2,01513 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Checking value in textbox against an array script not working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related