Using the name "function" for a variable in Python code

Question

Is using the word function for the name of an argument considered bad style in Python code?

def conjunction_junction(function):
    pass # do something and call function in here

This pattern occurs all the time, especially in decorators. You see func, fn and f used all of the time but I prefer to avoid abbreviations when possible. Is the fact that it's the name of a type enough to warrant abbreviating it?

>> type(conjunction_junction).__name__
'function'

As long as it doesn't override anything and it doesn't cause syntax color issues (it doesn't) - I personally don't mind. — Yuji 'Tomita' Tomita
– Yuji 'Tomita' Tomita, Commented Jun 9, 2012 at 2:02
@Mike: That's because SO uses a generic highlighter. Let me add the language tag so it highlights properly. — Niklas B.
– Niklas B., Commented Jun 9, 2012 at 2:17
> I prefer to avoid abbreviations when possible < A great philosophy (mine as well)! There's no problem with using function, but given how common func is, I wouldn't be against abbreviating this specific name. — Casey Kuball
– Casey Kuball, Commented Jun 9, 2012 at 2:34

user545424 · Accepted Answer · 2012-06-09 02:01:43Z

3

It's not a reserved keyword, so I don't see why not.

From the Style Guide

If a function argument's name clashes with a reserved keyword, it is generally better to append a single trailing underscore rather than use an abbreviation or spelling corruption. Thus class_ is better than clss. (Perhaps better is to avoid such clashes by using a synonym.)

answered Jun 9, 2012 at 2:01

user545424

16.3k11 gold badges61 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Niklas B. Over a year ago

str and list are also no reserved keywords. You still want to avoid using them as identifiers. Of course in this case, function is also not a builtin class, module or function name, so it's okay to use it (though I've seen func being used more commonly, maybe for the exact same reason that OP started the question: they weren't sure whether it's okay to use function)

Joel Cornett · Accepted Answer · 2012-06-09 02:10:08Z

3

Using function is perfectly fine.

There is nothing in the style guide about it specifically. The reason that the use of type names such as str and list is highly discouraged is because they have functionality within the language. Overwriting them would obscure the functionality of the code. function on the other hand, does nothing.

I suspect func, fn, and f are used because they are all shorter than typing function ;)

answered Jun 9, 2012 at 2:10

Joel Cornett

24.8k9 gold badges69 silver badges90 bronze badges

Collectives™ on Stack Overflow

Using the name "function" for a variable in Python code

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related