Pulling Form Variables through Javascript in a For Loop

Question

I have a webpage that based on user input populates with form fields, as done by the following:

        function Go2() {
            var loans = document.getElementById('count').value;
            var content = document.getElementById('stage3').innerHTML;
            content = '<TABLE Width="100%">'
                +'<TR>'
                +'<TD Style="font-weight:bold;" Width="30%">Customer Name</TD>'
                +'<TD Style="font-weight:bold;" Width="30%">Customer Number</TD>'
                +'<TD Style="font-weight:bold;" Width="30%">Origination Date</TD>'
                +'</TR>'
                +'</TABLE>';
            document.getElementById('stage3').innerHTML = content;
            for(var i=0; i<loans; i++) {
                content = document.getElementById('stage3').innerHTML;
                document.getElementById('stage3').innerHTML = content
                    + '<TABLE Width="100%">'
                    + '<TR>'
                    + '<TD Width="30%"><INPUT Name="CName'
                    + i
                    + '" Size="40" Type="text"></TD>'
                    + '<TD Width="30%"><INPUT Name="CNumber'
                    + i
                    + '" Size="40" Type="text"></TD>'
                    + '<TD Width="30%"><INPUT Name="Date'
                    + i
                    + '" Size="40" Type="text"></TD>'
                    + '</TR>'
                    + '</TABLE>';
            }
            content = document.getElementById('stage3').innerHTML;
            document.getElementById('stage3').innerHTML = content
                    + '<TABLE><TR><TD><INPUT Type="Button" Value="Submit" onClick="Go3()"></TD></TR></TABLE>';
        }

Now what I need to do is iterate through the form and pull out the values for each of the form fields. This is about as far as I've gotten:

for (var n=0; n<loans; n++) {
content += '<TR>'
    + '<TD Colspan="2">'
    + document.getElementById('CName + n').value
    + '</TD>'
    + '<TD Colspan="2">'
    + document.getElementById('CNumber + n').value
    + '</TD>'
    + '<TD>'
    + document.getElementById('Date + n').value
    + '</TD>'
    + '</TR>';
}

Which does...Nothing. The last notable progress I had was getting it to spit out "null" which isn't really progress at all. I've looked at eval, but there's quite a few warnings against it.

Any Ideas?

Josh Mc · Accepted Answer · 2012-05-21 21:48:42Z

1

I think you want

document.getElementById('CName' + n).value

(where n is outside of the quotes)

answered May 21, 2012 at 21:48

Josh Mc

10.3k8 gold badges57 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user1408456 Over a year ago

pastebin.com/eh1Qe7aW is the function as a whole, it still doesn't do anything when I click submit :\

Josh Mc Over a year ago

Your inputs also need to be id="CName..." NOT name="CName..."

user1408456 Over a year ago

Nevermind, No i didn't, thank you, I've been staring at this for far to long.

Josh Mc Over a year ago

No problem, I know the feeling :)

gotofritz · Accepted Answer · 2012-05-21 21:49:08Z

1

Well it should be 'CName' + n - i.e., you got the quotation marks in the wrong place

answered May 21, 2012 at 21:49

gotofritz

3,3912 gold badges33 silver badges49 bronze badges

Comments

RobG · Accepted Answer · 2012-05-22 00:34:13Z

0

If all your controls are in a form, then you can access them as:

var allControls = document.<formId>.elements;

or

var allControls = document.forms[formId].elements;

Then iterate over the list of controls to get the values. The form controls must have names to be successful, no need for IDs. You can also get the values as:

var value = allControls['CName' + n].value;

or just

var form = docment.forms[formID];
var value = form['CName' + n].value;

answered May 22, 2012 at 0:34

RobG

148k32 gold badges180 silver badges216 bronze badges

Collectives™ on Stack Overflow

Pulling Form Variables through Javascript in a For Loop

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related