Skip to content

Conversation

@sl-1314
Copy link
Contributor

@sl-1314 sl-1314 commented Nov 21, 2025

What does this PR do?

This PR mainly supports reward_loop for recipe/fully_async_policy.
The main changes are as follows:

  • refactor recipe/fully_async_policy to support reward_loop
  • fix recipe/fully_async_policy final validation bug
  • extract _agent_loop_postprocess: Move the padding/mask/position-id post-processing logic out of _run_agent_loop into a dedicated function async def _agent_loop_postprocess(...).
  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for reward_loop in the fully asynchronous policy, involving a significant refactoring of the rollout process. The changes simplify the data flow by removing the intermediate result_queue and integrate the consumer logic directly into the processor. The fix for the final validation logic also appears more robust. My review focuses on improving exception handling for better debuggability and addressing code duplication to enhance maintainability.

sl-1314 and others added 4 commits November 21, 2025 15:31
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants