Skip to content

Replace waitForElement to waitFor to remove warnings #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Replace waitForElement to waitFor to remove warnings #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/react-testing-library/example-intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ See the following sections for a detailed breakdown of the test
```jsx
// __tests__/fetch.test.js
import React from 'react'
import { render, fireEvent, waitForElement, screen } from '@testing-library/react'
import { render, fireEvent, waitFor, screen } from '@testing-library/react'
import '@testing-library/jest-dom/extend-expect'
import axiosMock from 'axios'
import Fetch from '../fetch'
Expand All @@ -28,7 +28,7 @@ test('loads and displays greeting', async () => {

fireEvent.click(screen.getByText('Load Greeting'))

await waitForElement(() => screen.getByRole('heading'))
await waitFor(() => screen.getByRole('heading'))

expect(axiosMock.get).toHaveBeenCalledTimes(1)
expect(axiosMock.get).toHaveBeenCalledWith(url)
Expand All @@ -48,7 +48,7 @@ test('loads and displays greeting', async () => {
import React from 'react'

// import react-testing methods
import { render, fireEvent, waitForElement, screen } from '@testing-library/react'
import { render, fireEvent, waitFor, screen } from '@testing-library/react'

// add custom jest matchers from jest-dom
import '@testing-library/jest-dom/extend-expect'
Expand Down Expand Up @@ -91,9 +91,9 @@ fireEvent.click(getByText('Load Greeting'))

// Wait until the mocked `get` request promise resolves and
// the component calls setState and re-renders.
// `waitForElement` waits until the callback doesn't throw an error
// `waitFor` waits until the callback doesn't throw an error

await waitForElement(() =>
await waitFor(() =>
// getByRole throws an error if it cannot find an element
screen.getByRole('heading')
)
Expand Down