Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Nov 21, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ @​emnapi/core (1.6.0 → 1.7.1) · Repo

Release Notes

1.7.1

What's Changed

Full Changelog: v1.7.0...v1.7.1

1.7.0

What's Changed

Full Changelog: v1.6.0...v1.7.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot requested a review from a team as a code owner November 21, 2025 07:10
@depfu depfu bot added the depfu label Nov 21, 2025
@depfu
Copy link
Contributor Author

depfu bot commented Nov 21, 2025

Sorry, but the merge failed with:

At least 1 approving review is required by reviewers with write access.

@depfu depfu bot force-pushed the depfu/update/pnpm/@emnapi/core-1.7.1 branch from 94cc882 to e09057e Compare November 21, 2025 14:45
@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025

Walkthrough

This pull request updates the @emnapi/core dependency in the WebAssembly package configuration. The version is bumped from ^1.6.0 to ^1.7.1 in crates/node/npm/wasm32-wasi/package.json. This is a maintenance update to the dependency version constraint. No public API changes, new exports, error handling modifications, or control-flow alterations are introduced by this change.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: updating @emnapi/core from version 1.6.0 to 1.7.1.
Description check ✅ Passed The PR description is directly related to the changeset, providing detailed release notes, commits, and context for the @emnapi/core dependency update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 385edfb and e09057e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • crates/node/npm/wasm32-wasi/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Linux / cli
  • GitHub Check: Linux / upgrade
  • GitHub Check: Linux / postcss
  • GitHub Check: Linux / vite
  • GitHub Check: Linux
  • GitHub Check: Windows
  • GitHub Check: macOS
🔇 Additional comments (1)
crates/node/npm/wasm32-wasi/package.json (1)

31-31: Version bump aligns @emnapi/core with @emnapi/runtime.

The update to ^1.7.1 brings @emnapi/core in line with @emnapi/runtime (line 32), which is already at this version. Since both are bundled together (lines 39–40), keeping them in sync is good practice for compatibility.

According to the PR description, v1.7.1 introduces Node-API version detection and SharedArrayBuffer support in napi_create_dataview. Please verify that:

  1. The new features don't require code changes in the WASM package or downstream consumers
  2. The build and test suite pass with this version upgrade

If you'd like, I can generate a verification script to check for any build issues or breaking changes.


Comment @coderabbitai help to get the list of available commands and usage tips.

@depfu depfu bot merged commit a1f533a into main Nov 21, 2025
9 checks passed
@depfu depfu bot deleted the depfu/update/pnpm/@emnapi/core-1.7.1 branch November 21, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants