Skip to content

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 24, 2025

Description:

This shows up in the profiling result, so I made it explicit about whether we should commit the pending semicolon or drop it. I think it showed up in the profiling result because I used &dyn, but using &dyn is a useful technique for reducing the binary size.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 24, 2025
@kdy1 kdy1 self-assigned this Jan 24, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 24, 2025 09:58
@kdy1 kdy1 marked this pull request as draft January 24, 2025 09:58
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 0033f64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 removed this from the Planned milestone Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

es/codegen: commit_pending_semi should be explicit

1 participant