fix: ensure everything works and instructions updated #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr makes a couple changes. - Updates the README to be more inline with the one in https://github.com/scala/scala3-example-project - Updates mill to the latest and adds in a .mill-version file - Fixes the build - closes scala#13 - Makes the structure a bit more "mill like" instead of using the SbtModule (opinionated, but will be more what you actually see in the wild as I've never personally seen SbtModule used) - Gets rid of random sbt files like build.sbt and project/ - updated the stuff in the workflow to use coursier cache action
Member
|
review by @anatoliykmetyuk, perhaps? |
anatoliykmetyuk
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes a couple changes.
SbtModule (opinionated, but will be more what you actually see in
the wild as I've never personally seen SbtModule used)