Handle cycles when checking impl candidates for doc(hidden)
#149185
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
Member
|
Thanks! |
Collaborator
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 22, 2025
…yukang Handle cycles when checking impl candidates for `doc(hidden)` Fixes rust-lang#149092
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
…yukang Handle cycles when checking impl candidates for `doc(hidden)` Fixes rust-lang#149092
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
…yukang Handle cycles when checking impl candidates for `doc(hidden)` Fixes rust-lang#149092
bors
added a commit
that referenced
this pull request
Nov 22, 2025
Rollup of 8 pull requests Successful merges: - #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts) - #148407 (Warn against calls which mutate an interior mutable `const`-item) - #149168 (Fix ICE when collecting opaques from trait method declarations) - #149170 (automate gpu offloading - part 1) - #149180 (Couple of refactors to SharedEmitter) - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - #149194 (Move safe computation out of unsafe block) - #149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
…yukang Handle cycles when checking impl candidates for `doc(hidden)` Fixes rust-lang#149092
bors
added a commit
that referenced
this pull request
Nov 22, 2025
Rollup of 7 pull requests Successful merges: - #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts) - #148407 (Warn against calls which mutate an interior mutable `const`-item) - #149168 (Fix ICE when collecting opaques from trait method declarations) - #149170 (automate gpu offloading - part 1) - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - #149194 (Move safe computation out of unsafe block) - #149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149092